Skip to content

cephfs-mirror: use monotonic clocks#55701

Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom
joscollin:wip-B62265-use-monotonic-clocks
Apr 4, 2024
Merged

cephfs-mirror: use monotonic clocks#55701
rishabh-d-dave merged 1 commit intoceph:mainfrom
joscollin:wip-B62265-use-monotonic-clocks

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Feb 22, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/62265

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the cephfs Ceph File System label Feb 22, 2024
@joscollin joscollin requested a review from vshankar February 22, 2024 05:42
@vshankar vshankar requested a review from a team February 22, 2024 05:44
@joscollin
Copy link
Member Author

joscollin commented Feb 22, 2024

jenkins test signed

@joscollin
Copy link
Member Author

joscollin commented Feb 22, 2024

jenkins retest this please

@joscollin joscollin force-pushed the wip-B62265-use-monotonic-clocks branch from d118941 to 4945157 Compare February 22, 2024 12:44
rishabh-d-dave
rishabh-d-dave approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Feb 22, 2024

@joscollin Since you pushed another set of changes after Dhairya approved, is this PR ready? If so, I'll pick it up for QA.

@joscollin
Copy link
Member Author

joscollin commented Feb 22, 2024

@rishabh-d-dave @dparmar18 Please check again. Updated the review comments as a separate commit.

@dparmar18
Copy link
Contributor

dparmar18 commented Feb 22, 2024

@rishabh-d-dave @dparmar18 Please check again. Updated the review comments as a separate commit.

LGTM :)

@joscollin
cephfs-mirror: use monotonic clock
7f0e7fe 
Fixes: https://tracker.ceph.com/issues/62265
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin joscollin force-pushed the wip-B62265-use-monotonic-clocks branch from e274012 to 7f0e7fe Compare February 22, 2024 14:41
@joscollin
Copy link
Member Author

joscollin commented Feb 22, 2024

squashed commits

@joscollin
Copy link
Member Author

joscollin commented Feb 22, 2024

@joscollin Since you pushed another set of changes after Dhairya approved, is this PR ready? If so, I'll pick it up for QA.

@rishabh-d-dave Please pick up for qa. Thanks.

@rishabh-d-dave rishabh-d-dave added wip-rishabh-testing Rishabh's testing label and removed needs-qa labels Feb 22, 2024
rishabh-d-dave
rishabh-d-dave approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do multiple QA runs and re-runs due to build issues (due to one of the PRs in testing branch), unrelated issues in FS test suite, unrelated issues in testing kernel and new failures in every run that needed to ensured that they were unrelated to PRs in testing branch.

I finally have a run that is better than others - https://tracker.ceph.com/projects/cephfs/wiki/Main#4-Apr-2024. Sorry for the delay.

@rishabh-d-dave rishabh-d-dave merged commit fa256fa into ceph:main Apr 4, 2024
@joscollin joscollin deleted the wip-B62265-use-monotonic-clocks branch April 4, 2024 12:37
@leonid-s-usov leonid-s-usov mentioned this pull request Jun 16, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dparmar18 dparmar18 dparmar18 approved these changes

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

@vshankar vshankar Awaiting requested review from vshankar

Assignees

No one assigned

Labels

bug-fix cephfs Ceph File System wip-rishabh-testing Rishabh's testing label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joscollin @rishabh-d-dave @dparmar18