Skip to content

mgr/dashboard: introduce multi cluster management and monitoring in ceph dashboard #55574

Merged
nizamial09 merged 3 commits intomainfrom
feature-multi-cluster-management-monitoring
Mar 6, 2024
Merged

mgr/dashboard: introduce multi cluster management and monitoring in ceph dashboard #55574
nizamial09 merged 3 commits intomainfrom
feature-multi-cluster-management-monitoring

Conversation

@aaSharma14
Copy link
Copy Markdown
Contributor

@aaSharma14 aaSharma14 commented Feb 14, 2024

introduce multi cluster management and monitoring in ceph dashboard

Signed-off-by: Aashish Sharma aasharma@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@aaSharma14 aaSharma14 requested a review from a team as a code owner February 14, 2024 07:07
@aaSharma14 aaSharma14 requested review from avanthakkar and cloudbehl and removed request for a team February 14, 2024 07:07
@aaSharma14
Copy link
Copy Markdown
Contributor Author

aaSharma14 commented Feb 14, 2024

jenkins test make check

1 similar comment
@aaSharma14
Copy link
Copy Markdown
Contributor Author

aaSharma14 commented Feb 14, 2024

jenkins test make check

@nizamial09 nizamial09 changed the title mgr/dashboard: introduce multi cluster management and monitoring in ceph dashboard mgr/dashboard: introduce multi cluster management and monitoring in ceph dashboard Feb 14, 2024
@nizamial09 nizamial09 added the DNM label Feb 14, 2024
@nizamial09
Copy link
Copy Markdown
Member

nizamial09 commented Feb 14, 2024

jenkins test dashboard

@nizamial09
Copy link
Copy Markdown
Member

nizamial09 commented Feb 14, 2024

jenkins test dashboard cephadm

@nizamial09 nizamial09 changed the title mgr/dashboard: introduce multi cluster management and monitoring in ceph dashboard [DNM] mgr/dashboard: introduce multi cluster management and monitoring in ceph dashboard Feb 14, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 14, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@nizamial09 nizamial09 force-pushed the feature-multi-cluster-management-monitoring branch from a0c579f to a73ca7a Compare February 22, 2024 05:09
nizamial09 and others added 2 commits February 22, 2024 10:41
@nizamial09
mgr/dashboard: multi-cluster management in ceph dashboard
3f21557 
Fixes: https://tracker.ceph.com/issues/64530
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@nizamial09
mgr/dashboard: Add a manage clusters page to the multi-cluster nav to
495f669 
list/connect/disconnect/edit clusters in multi-cluster setup

Fixes: https://tracker.ceph.com/issues/64530
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@nizamial09 nizamial09 force-pushed the feature-multi-cluster-management-monitoring branch from a73ca7a to 03cbe26 Compare February 22, 2024 05:12
@nizamial09 nizamial09 mentioned this pull request Feb 27, 2024
Merged
14 tasks
@cloudbehl cloudbehl mentioned this pull request Feb 27, 2024
Merged
14 tasks
@nizamial09 nizamial09 changed the title [DNM] mgr/dashboard: introduce multi cluster management and monitoring in ceph dashboard mgr/dashboard: introduce multi cluster management and monitoring in ceph dashboard Mar 1, 2024
@nizamial09
Copy link
Copy Markdown
Member

nizamial09 commented Mar 1, 2024

jenkins retest this please

@nizamial09
Copy link
Copy Markdown
Member

nizamial09 commented Mar 4, 2024

@aaSharma14 this looks like an actual e2e failure

  Shared pages
    ✓ should display the vertical menu by default
    ✓ should hide the vertical menu
    1) should navigate to the correct page


  2 passing (4m)
  1 failing

  1) Shared pages
       should navigate to the correct page:
     AssertionError: Timed out retrying after 120000ms: Expected to find content: 'Pools' within the element: <li.nav-item.tc_menuitem_multi_cluster> and with the selector: 'ul.list-unstyled li a' but never did.
      at Context.eval (cypress/e2e/ui/navigation.po.ts:93:11)

@aaSharma14 aaSharma14 force-pushed the feature-multi-cluster-management-monitoring branch 2 times, most recently from 7f7278f to bd0ac66 Compare March 5, 2024 05:45
@nizamial09
Copy link
Copy Markdown
Member

nizamial09 commented Mar 5, 2024

jenkins test make check

@nizamial09
Copy link
Copy Markdown
Member

nizamial09 commented Mar 5, 2024

the e2e error is still there btw

    1) should navigate to the correct page


  2 passing (4m)
  1 failing

  1) Shared pages
       should navigate to the correct page:
     AssertionError: Timed out retrying after 120000ms: Expected to find content: 'Pools' within the element: <li.nav-item.tc_menuitem_multi_cluster.active> and with the selector: 'ul.list-unstyled li a' but never did.
      at Context.eval (cypress/e2e/ui/navigation.po.ts:100:11)

@nizamial09
mgr/dashboard: introduce multi-cluster overview page
b8811c8 
https://tracker.ceph.com/issues/64530
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@aaSharma14 aaSharma14 force-pushed the feature-multi-cluster-management-monitoring branch from bd0ac66 to b8811c8 Compare March 5, 2024 13:36
@nizamial09 nizamial09 merged commit 278daa4 into main Mar 6, 2024
@nizamial09 nizamial09 deleted the feature-multi-cluster-management-monitoring branch March 6, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nizamial09 nizamial09 nizamial09 approved these changes

@cloudbehl cloudbehl Awaiting requested review from cloudbehl cloudbehl is a code owner automatically assigned from ceph/dashboard

@avanthakkar avanthakkar Awaiting requested review from avanthakkar avanthakkar is a code owner automatically assigned from ceph/dashboard

Assignees

No one assigned

Labels

api-change dashboard DNM monitoring pybind

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaSharma14 @nizamial09