Skip to content

reef: qa/tasks/cephadm: enable mon_cluster_log_to_file#55431

Merged
yuriw merged 1 commit intoceph:reeffrom
adk3798:reef-mcltf-true
Mar 5, 2025
Merged

reef: qa/tasks/cephadm: enable mon_cluster_log_to_file#55431
yuriw merged 1 commit intoceph:reeffrom
adk3798:reef-mcltf-true

Conversation

@adk3798
Copy link
Contributor

@adk3798 adk3798 commented Feb 2, 2024

Without cluster_log_to_file we have nothing to grep for errors:

2023-10-27T16:06:59.111 DEBUG:teuthology.orchestra.run.smithi150:> sudo egrep '\[ERR\]|\[WRN\]|\[SEC\]' /var/log/ceph/38cc7fce-74d9-11ee-8db9-212e2dc638e7/ceph.log | egrep -v '\(MDS_ALL_DOWN\)' | egrep -v '\(MDS_UP_LESS_THAN_MAX\)' | head -n 1
2023-10-27T16:06:59.141 INFO:teuthology.orchestra.run.smithi150.stderr:grep: /var/log/ceph/38cc7fce-74d9-11ee-8db9-212e2dc638e7/ceph.log: No such file or directory

Set mon_cluster_log_to_file = true.

Fixes: https://tracker.ceph.com/issues/63425
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
(cherry picked from commit 822e6b0)
(cherry picked from commit df79c84)
@adk3798 adk3798 added this to the reef milestone Feb 2, 2024
@idryomov
Copy link
Contributor

idryomov commented Feb 8, 2024

jenkins test windows

@idryomov
Copy link
Contributor

idryomov commented Feb 8, 2024

Not assigning to 18.2.x milestone until there is clarity on https://tracker.ceph.com/issues/64343.

@ljflores
Copy link
Member

Not assigning to 18.2.x milestone until there is clarity on https://tracker.ceph.com/issues/64343.

Thanks Ilya, my take on this is that we should run this through the rados/orch suite, get results, and then create a commit to address whitelisting as was done in this PR: #55523

Although, for reef (and quincy), I would prefer to have these pieces merge together.

Copy link
Member

@ljflores ljflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this until we have a commit to whitelist appropriate warnings in the rados/orch suite (I can help with this). We can put this PR through the rados suite, and then use the results to create the whitelist commit.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 26, 2024
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Dec 26, 2024
@idryomov
Copy link
Contributor

idryomov commented Feb 1, 2025

Reopening for this to go with #61434.

@idryomov idryomov reopened this Feb 1, 2025
@idryomov idryomov modified the milestones: reef, v18.2.5 Feb 1, 2025
@idryomov idryomov added needs-qa and removed stale labels Feb 1, 2025
@adamemerson
Copy link
Contributor

jenkins test windows

@adamemerson adamemerson requested a review from ljflores February 13, 2025 18:38
@NitzanMordhai
Copy link
Contributor

@adamemerson
Copy link
Contributor

Rados approved: https://tracker.ceph.com/projects/rados/wiki/REEF#httpstrackercephcomissues69634

@ljflores Is this enough to unblock the PR?

@yuriw yuriw merged commit 2db28f8 into ceph:reef Mar 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants