Skip to content

pacific: qa/tasks/cephadm: enable mon_cluster_log_to_file#55429

Merged
adk3798 merged 1 commit intoceph:pacificfrom
adk3798:pacific-mcltf-true
Feb 8, 2024
Merged

pacific: qa/tasks/cephadm: enable mon_cluster_log_to_file#55429
adk3798 merged 1 commit intoceph:pacificfrom
adk3798:pacific-mcltf-true

Conversation

@adk3798
Copy link
Contributor

@adk3798 adk3798 commented Feb 2, 2024 •
edited by batrick
Loading

@dvanders @adk3798
qa/tasks/cephadm: enable mon_cluster_log_to_file
f36b27a 
Without cluster_log_to_file we have nothing to grep for errors:

2023-10-27T16:06:59.111 DEBUG:teuthology.orchestra.run.smithi150:> sudo egrep '\[ERR\]|\[WRN\]|\[SEC\]' /var/log/ceph/38cc7fce-74d9-11ee-8db9-212e2dc638e7/ceph.log | egrep -v '\(MDS_ALL_DOWN\)' | egrep -v '\(MDS_UP_LESS_THAN_MAX\)' | head -n 1
2023-10-27T16:06:59.141 INFO:teuthology.orchestra.run.smithi150.stderr:grep: /var/log/ceph/38cc7fce-74d9-11ee-8db9-212e2dc638e7/ceph.log: No such file or directory

Set mon_cluster_log_to_file = true.

Fixes: https://tracker.ceph.com/issues/63425
Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
(cherry picked from commit 822e6b0)
@github-actions github-actions bot added the tests label Feb 2, 2024
@adk3798 adk3798 added this to the v16.2.15 milestone Feb 2, 2024
@github-actions github-actions bot modified the milestones: v16.2.15, pacific Feb 2, 2024
@adk3798 adk3798 added the cephadm label Feb 2, 2024
@yuriw yuriw modified the milestones: pacific, v16.2.15 Feb 2, 2024
@idryomov
Copy link
Contributor

idryomov commented Feb 4, 2024 •
edited
Loading

Noting that this also includes #41479.

@ljflores
Copy link
Member

ljflores commented Feb 7, 2024 •
edited
Loading

I reviewed the PR. This did cause some new red jobs to appear in the rados suite, but most are warnings that are expected in test environments, and thus should be whitelisted. I raised the following tracker tickets to address the whitelists (although I don’t think it should block the merge of this PR):
https://tracker.ceph.com/issues/64343
https://tracker.ceph.com/issues/64344

Regarding map eXX had wrong heartbeat addr, it looks like the same issue as https://tracker.ceph.com/issues/58915 . I have asked @rzarzynski to take a look and see if the fix needs to be included in pacific.

Finally , I noticed a cephadm bug that looks new. @adk3798 wdyt of https://tracker.ceph.com/issues/53154 ? It was caught when the job failed from CEPHADM_STRAY_DAEMON in the cluster log. Is it a true bug or should we whitelist that warning?

In summary, everything that needs to be whitelisted now in the rados suite has a tracker, so I am okay with merging this PR since it has already merged to main.

Rados approved; full summary: https://tracker.ceph.com/projects/rados/wiki/PACIFIC#httpstrellocomcERqmvaZu1947-wip-yuri10-testing-2024-02-02-1149-pacific

@adk3798 adk3798 merged commit f44040a into ceph:pacific Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idryomov idryomov idryomov approved these changes

Assignees

No one assigned

Labels

cephadm tests wip-yuri10-testing

Projects

None yet

Milestone

v16.2.15

Development

Successfully merging this pull request may close these issues.

5 participants

@adk3798 @idryomov @ljflores @yuriw @dvanders