mon: fix health store size growing infinitely#55347
Merged
Conversation
The `check_mutes` wrongly marks `changed` to true, trigger `propose_pending` and block following `maybe_trim` logic (`have_pending` will be always be false); as a result, the health store will never be trimmed. Signed-off-by: Wei Wang <lightmelodies@outlook.com>
Contributor
Author
|
@tchaikov PTAL |
Contributor
Author
|
@cbodley PTAL |
Matan-B
approved these changes
Feb 6, 2024
Contributor
Matan-B
left a comment
There was a problem hiding this comment.
LGTM, let's backport this
Contributor
|
jenkins test make check |
rzarzynski
approved these changes
Feb 6, 2024
| bool HealthMonitor::check_mutes() | ||
| { | ||
| bool changed = true; | ||
| bool changed = false; |
Contributor
There was a problem hiding this comment.
Yeah, the intention is clear here.
14 tasks
This was referenced Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://tracker.ceph.com/issues/64236
We have recently encountered
MON_DISK_BIGin a large production cluster with all pgactive+clean. The paxos log shows that the first committed version of health store stay at1, while last committed version grows periodically.We then found
HealthMonitor::check_muteswrongly markschangedto true, triggerpropose_pendingand block followingmaybe_trimlogic (have_pendingwill be always be false); as a result, the health store will never be trimmed.This also cause unnecessary paxos propose even no change has been found.
ceph/src/mon/HealthMonitor.cc
Lines 393 to 399 in 93c567e
ceph/src/mon/Monitor.cc
Lines 5892 to 5894 in 93c567e
ceph/src/mon/PaxosService.cc
Lines 385 to 388 in 93c567e
ceph/src/mon/PaxosService.h
Lines 548 to 550 in 93c567e
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e