Skip to content

tools/rados: allow to read setomapheader value from file#55334

Merged
yuriw merged 1 commit intoceph:mainfrom
trociny:wip-rados-setomapheader
Oct 1, 2024
Merged

tools/rados: allow to read setomapheader value from file#55334
yuriw merged 1 commit intoceph:mainfrom
trociny:wip-rados-setomapheader

Conversation

@trociny
Copy link
Contributor

@trociny trociny commented Jan 27, 2024

(similarly to setomapval)

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@trociny trociny requested a review from a team as a code owner January 27, 2024 09:18
@github-actions github-actions bot added the core label Jan 27, 2024
@trociny trociny added tools and removed core labels Jan 27, 2024
@ifed01
Copy link
Contributor

ifed01 commented Jan 29, 2024

jenkins test api

@ifed01
Copy link
Contributor

ifed01 commented Jan 29, 2024

jenkins test docs

@github-actions
Copy link

github-actions bot commented Mar 29, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 29, 2024
@trociny
tools/rados: allow to read setomapheader value from file
8e61af9 
(similarly to setomapval)

Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
@trociny trociny force-pushed the wip-rados-setomapheader branch from c2110dd to 8e61af9 Compare March 29, 2024 12:41
@github-actions github-actions bot added the core label Mar 29, 2024
@trociny trociny removed the stale label Mar 29, 2024
@trociny
Copy link
Contributor Author

trociny commented May 12, 2024

jenkins retest this please

@github-actions
Copy link

github-actions bot commented Jul 11, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jul 11, 2024
@ifed01 ifed01 added needs-qa and removed stale labels Jul 11, 2024
@ljflores
Copy link
Member

ljflores commented Jul 23, 2024

jenkins test make check

@ljflores
Copy link
Member

ljflores commented Jul 23, 2024

jenkins test api

@ljflores
Copy link
Member

ljflores commented Jul 31, 2024

Rados approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues67090

@yuriw
Copy link
Contributor

yuriw commented Jul 31, 2024

jenkins test this please

@yuriw
Copy link
Contributor

yuriw commented Jul 31, 2024

@trociny pls merge when all checks passed
ref: https://tracker.ceph.com/issues/67090

@trociny
Copy link
Contributor Author

trociny commented Aug 1, 2024

jenkins test this please

@ljflores
Copy link
Member

ljflores commented Aug 5, 2024

jenkins retest this please

@yuriw
Copy link
Contributor

yuriw commented Aug 8, 2024

jenkins test api

1 similar comment
@yuriw
Copy link
Contributor

yuriw commented Aug 26, 2024

jenkins test api

@ronen-fr
Copy link
Contributor

ronen-fr commented Sep 24, 2024

Approved (core) (https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues67878)

@yuriw yuriw merged commit 228fbaa into ceph:main Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ifed01 ifed01 ifed01 approved these changes

Assignees

No one assigned

Labels

core needs-qa ready-to-merge TESTED tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@trociny @ifed01 @ljflores @yuriw @ronen-fr @SrinivasaBharath