Skip to content

osd: add mclock queue perfcounter#55295

Closed
jianwei1216 wants to merge 1 commit intoceph:mainfrom
jianwei1216:feat_add_counter_for_mclock_queue
Closed

osd: add mclock queue perfcounter#55295
jianwei1216 wants to merge 1 commit intoceph:mainfrom
jianwei1216:feat_add_counter_for_mclock_queue

Conversation

@jianwei1216
Copy link
Contributor

@jianwei1216 jianwei1216 commented Jan 24, 2024 •
edited
Loading 

Easy to visualize the number of ops
in each subqueue of mclock.

Add request statistics for each
op_scheduler_class

ceph daemon osd.0 perf dump osd
{
    "osd": {
        "mclock_immdiate_op": 640,
        "mclock_client_op": 1229,
        "mclock_recovery_op": 887,
        "mclock_best_effort_op": 925
    }
}

https://tracker.ceph.com/issues/64167

@jianwei1216 jianwei1216 requested a review from a team as a code owner January 24, 2024 09:28
@github-actions github-actions bot added the core label Jan 24, 2024
@jianwei1216 jianwei1216 force-pushed the feat_add_counter_for_mclock_queue branch from fa92570 to 2b4c0fa Compare January 24, 2024 09:29
@jianwei1216
Copy link
Contributor Author

jianwei1216 commented Jan 24, 2024

I will create an issue later

@jianwei1216 jianwei1216 force-pushed the feat_add_counter_for_mclock_queue branch 3 times, most recently from 2ec5bb1 to 5d714e4 Compare January 24, 2024 14:10
@github-actions github-actions bot added the tests label Jan 24, 2024
@tchaikov
Copy link
Contributor

tchaikov commented Jan 24, 2024

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes

@jianwei1216
Copy link
Contributor Author

jianwei1216 commented Jan 24, 2024

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes

好的，还在测试中，延续了当前公司的命名约束

@jianwei1216 jianwei1216 force-pushed the feat_add_counter_for_mclock_queue branch from 5d714e4 to da5c465 Compare January 24, 2024 14:23
@jianwei1216 jianwei1216 changed the title feat: add mclock queue perfcounter osd: add mclock queue perfcounter Jan 24, 2024
@jianwei1216
Copy link
Contributor Author

jianwei1216 commented Jan 25, 2024

@sseshasa @athanatos @rzarzynski What do you think？Thank you.

sseshasa
sseshasa requested changes Jan 25, 2024
View reviewed changes
sseshasa
sseshasa requested changes Jan 25, 2024
View reviewed changes
@jianwei1216 jianwei1216 force-pushed the feat_add_counter_for_mclock_queue branch 2 times, most recently from 97cd818 to 250299e Compare January 29, 2024 08:10
osd: add mclock queue perfcounter
868e0fb 
Easy to visualize the number of ops
in each subqueue of mclock.

Add request statistics for each
op_scheduler_class

ceph daemon osd.0 perf dump osd
{
    "osd": {
        "mclock_immdiate_op": 640,
        "mclock_client_op": 1229,
        "mclock_store_db_op": 129,
        "mclock_recovery_op": 887,
        "mclock_best_effort_op": 925
    }
}

Signed-off-by: zhangjianwei2 <zhangjianwei2@cmss.chinamobile.com>
@jianwei1216 jianwei1216 force-pushed the feat_add_counter_for_mclock_queue branch from 250299e to 868e0fb Compare January 29, 2024 10:25
@jianwei1216
Copy link
Contributor Author

jianwei1216 commented Jan 29, 2024

jenkins test make check

@jianwei1216
Copy link
Contributor Author

jianwei1216 commented Jan 29, 2024

jenkins test make check (arm64)

@jianwei1216
Copy link
Contributor Author

jianwei1216 commented Jan 30, 2024

jenkins test make check

@github-actions
Copy link

github-actions bot commented Mar 30, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 30, 2024
@github-actions
Copy link

github-actions bot commented Apr 29, 2024

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Apr 29, 2024
@jianwei1216
Copy link
Contributor Author

jianwei1216 commented Jun 27, 2024

@sseshasa @athanatos Could you please reopen this PR for me?

@jianwei1216
Copy link
Contributor Author

jianwei1216 commented Jun 27, 2024

@sseshasa @athanatos Could you please reopen this PR for me?

I'll open a new PR.

Ignore

@jianwei1216
Copy link
Contributor Author

jianwei1216 commented Jun 27, 2024

NEW PR: #58302

@jianwei1216 jianwei1216 mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sseshasa sseshasa sseshasa requested changes

Assignees

No one assigned

Labels

core stale tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jianwei1216 @tchaikov @sseshasa