Skip to content

src/pybind/mgr/pg_autoscaler/module.py: fix 'pg_autoscale_mode' output#54968

Merged
yuriw merged 1 commit intoceph:mainfrom
kamoltat:wip-ksirivad-fix-63860
Jul 30, 2024
Merged

src/pybind/mgr/pg_autoscaler/module.py: fix 'pg_autoscale_mode' output#54968
yuriw merged 1 commit intoceph:mainfrom
kamoltat:wip-ksirivad-fix-63860

Conversation

@kamoltat
Copy link
Member

@kamoltat kamoltat commented Dec 19, 2023 •
edited
Loading

Problem:
ceph osd pool autoscale-status -f json
and ceph osd pool autoscale-status
shows discrepeencies between each other
in the pg_autoscale_mode section,
when no_autoscale flag is set.

This is due to not showing
the output correctly.

Solution:

shows false in pg_autoscale_mode for
both ceph osd pool autoscale-status and
the json version of the command if no_autoscale
is set.

it sounds like a simple solution, but the problem
is more of a display problem rather than logic.

Fixes: https://tracker.ceph.com/issues/63860

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@kamoltat kamoltat self-assigned this Dec 19, 2023
@kamoltat kamoltat requested a review from a team December 19, 2023 20:31
@kamoltat
Copy link
Member Author

kamoltat commented Feb 9, 2024

jenkins test make check

NitzanMordhai
NitzanMordhai requested changes Feb 11, 2024
View reviewed changes
Copy link
Contributor

@NitzanMordhai NitzanMordhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamoltat if we already doing another loop over ps, isn't it better to consider all other values that we are change for table view and move it before the check for json?

@github-actions
Copy link

github-actions bot commented Apr 11, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Apr 11, 2024
@kamoltat kamoltat removed the stale label Apr 26, 2024
@kamoltat
src/pybind/mgr/pg_autoscaler/module.py: fix 'pg_autoscale_mode' output
bd8d7e9 
Problem:
`ceph osd pool autoscale-status -f json`
and `ceph osd pool autoscale-status`
shows discrepeencies between each other
in the `pg_autoscale_mode` section,
when `no_autoscale` flag is set.

Solution:

set `pg_autoscale_mode` to `false` for
both `ceph osd pool autoscale-status` and
the json version of the command if `no_autoscale`
is set.

Fixes: https://tracker.ceph.com/issues/63860

Signed-off-by: Kamoltat <ksirivad@redhat.com>
@kamoltat kamoltat force-pushed the wip-ksirivad-fix-63860 branch from 60f56bf to bd8d7e9 Compare April 26, 2024 18:06
@kamoltat
Copy link
Member Author

kamoltat commented Apr 26, 2024

@NitzanMordhai thank you for your comment, I have addressed the changes you requested, I agree that the old change was hacky, hopefully, this one is more elegant.

Thanks

NitzanMordhai
NitzanMordhai approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@NitzanMordhai NitzanMordhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamoltat
Copy link
Member Author

kamoltat commented Apr 30, 2024

jenkins test make check

@kamoltat
Copy link
Member Author

kamoltat commented Apr 30, 2024

jenkins test api

@yuriw
Copy link
Contributor

yuriw commented May 3, 2024

This PR is under test in https://tracker.ceph.com/issues/65796.

@github-actions
Copy link

github-actions bot commented Jul 2, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jul 2, 2024
@kamoltat kamoltat removed the stale label Jul 18, 2024
@kamoltat
Copy link
Member Author

kamoltat commented Jul 18, 2024

RADOS APPROVED https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues65796

@kamoltat
Copy link
Member Author

kamoltat commented Jul 18, 2024

jenkins test api

1 similar comment
@yuriw
Copy link
Contributor

yuriw commented Jul 18, 2024

jenkins test api

@yuriw
Copy link
Contributor

yuriw commented Jul 18, 2024

@kamoltat pls merge when checks passed https://tracker.ceph.com/issues/65796
ref:

@kamoltat
Copy link
Member Author

kamoltat commented Jul 19, 2024 •
edited
Loading

jenkins test api

unrelated problem with dashboard api test

@yuriw yuriw merged commit 2e24db6 into ceph:main Jul 30, 2024
This was referenced Aug 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Matan-B Matan-B Matan-B approved these changes

@NitzanMordhai NitzanMordhai NitzanMordhai approved these changes

Assignees

@kamoltat kamoltat

Labels

core mgr needs-qa needs-quincy-backport backport required for quincy needs-reef-backport needs-squid-backport PR needs a squid backport pybind ready-to-merge TESTED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kamoltat @yuriw @Matan-B @NitzanMordhai @ljflores