Skip to content

quincy: os/bluestore: get rid off resulting lba alignment in allocators#54877

Merged
yuriw merged 2 commits intoceph:quincyfrom
ifed01:wip-ifed-no-alloc-lba-align-qui
Mar 4, 2024
Merged

quincy: os/bluestore: get rid off resulting lba alignment in allocators#54877
yuriw merged 2 commits intoceph:quincyfrom
ifed01:wip-ifed-no-alloc-lba-align-qui

Conversation

@ifed01
Copy link
Copy Markdown
Contributor

@ifed01 ifed01 commented Dec 12, 2023 •
edited
Loading

Parent tracker: https://tracker.ceph.com/issues/63618
Parent tracker: https://tracker.ceph.com/issues/62815

Backport of: #53483

Backport tracker: https://tracker.ceph.com/issues/63758
Backport tracker: https://tracker.ceph.com/issues/63761

Signed-off-by: Igor Fedotov igor.fedotov@croit.io

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@ifed01 ifed01 requested a review from a team as a code owner December 12, 2023 13:11
@github-actions github-actions bot added this to the quincy milestone Dec 12, 2023
@ifed01 ifed01 requested review from aclamk and pereman2 December 12, 2023 13:12
@pdvian
Copy link
Copy Markdown
Contributor

pdvian commented Jan 4, 2024 •
edited
Loading

@ifed01 Hi Igor, The StoreTestSpecificAUSize.BluestoreRepairSharedBlobTest failed while unmounting bluestore. Can you review the tracker#63938 and confirm whether it's related to the changes from this PR ?

RADOS suite review :

https://pulpito.ceph.com/yuriw-2024-01-03_21:31:38-rados-wip-yuri7-testing-2024-01-03-0857-quincy-distro-default-smithi/

Failures:

  1. https://tracker.ceph.com/issues/63938 ---> New tracker (seems to be related to PR#54877)
  2. https://tracker.ceph.com/issues/61578
  3. https://tracker.ceph.com/issues/63941 ---> New tracker
  4. https://tracker.ceph.com/issues/63748
  5. https://tracker.ceph.com/issues/62975

Details:

  1. rados/objectstore - assert in StoreTestSpecificAUSize.BluestoreRepairSharedBlobTest - Ceph - RADOS
  2. test_dashboard_e2e.sh: Can't run because no spec files were found - Ceph - Mgr - Dashboard
  3. rbd/test_librbd_python.sh: test failures - Ceph - RBD
  4. qa/workunits/post-file.sh: Couldn't create directory - Infrastructure
  5. site-packages/paramiko/channel.py: OSError: Socket is closed

@ifed01
os/bluestore: adjust and validate bluefs_shared_alloc_size
3de4bd5 
Make sure it's in-sync (meaning it's higher or equal and properly aligned)
with bluestore_min_alloc_size into account

Fixes: https://tracker.ceph.com/issues/63618
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 334e7fa)
@ifed01 ifed01 force-pushed the wip-ifed-no-alloc-lba-align-qui branch from 103dedb to 3c90c77 Compare January 10, 2024 15:59
@ifed01
Copy link
Copy Markdown
Contributor Author

ifed01 commented Jan 10, 2024

@ifed01 Hi Igor, The StoreTestSpecificAUSize.BluestoreRepairSharedBlobTest failed while unmounting bluestore. Can you review the tracker#63938 and confirm whether it's related to the changes from this PR ?

Confirmed and fixed within this PR. Thanks!

@ifed01
os/bluestore: get rid off resulting lba alignment in allocators
27c02c2 
Fixes: https://tracker.ceph.com/issues/62815

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit b0cb41a)
@ifed01 ifed01 force-pushed the wip-ifed-no-alloc-lba-align-qui branch from 3c90c77 to 27c02c2 Compare January 10, 2024 16:04
@ljflores ljflores modified the milestones: quincy, v17.2.8 Feb 27, 2024
@ljflores
Copy link
Copy Markdown
Member

ljflores commented Mar 4, 2024

Rados approved: https://tracker.ceph.com/projects/rados/wiki/QUINCY#httpstrellocomc9YxyBnTn1966-wip-yuri4-testing-2024-02-27-1111-quincy

@yuriw yuriw merged commit 79cf4d1 into ceph:quincy Mar 4, 2024
@ifed01 ifed01 deleted the wip-ifed-no-alloc-lba-align-qui branch March 4, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aclamk aclamk aclamk approved these changes

@pereman2 pereman2 Awaiting requested review from pereman2

Assignees

No one assigned

Labels

backport bluestore core needs-qa performance tests wip-yuri4-testing

Projects

None yet

Milestone

v17.2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@ifed01 @pdvian @ljflores @aclamk @yuriw