Skip to content

mgr/rgwam: period doesn't have a realm_name anymore#54864

Merged
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-mgr-rgw-realm-name
Dec 13, 2023
Merged

mgr/rgwam: period doesn't have a realm_name anymore#54864
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-mgr-rgw-realm-name

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Dec 11, 2023

the ceph rgw realm bootstrap command fails to parse the period output after #54264 removed the realm_name field:

debug 2023-12-08T01:00:40.065+0000 7f7678af4700 -1 mgr handle_command module 'rgw' command handler threw exception: 'realm_name'
debug 2023-12-08T01:00:40.065+0000 7f7678af4700 -1 mgr.server reply reply (22) Invalid argument Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 1801, in _handle_command
    return CLICommand.COMMANDS[cmd['prefix']].call(self, cmd, inbuf)
  File "/usr/share/ceph/mgr/mgr_module.py", line 474, in call
    return self.func(mgr, **kwargs)
  File "/usr/share/ceph/mgr/rgw/module.py", line 96, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/share/ceph/mgr/rgw/module.py", line 189, in _cmd_rgw_realm_bootstrap
    RGWAM(self.env).realm_bootstrap(spec, start_radosgw)
  File "/lib/python3.6/site-packages/ceph/rgw/rgwam_core.py", line 537, in realm_bootstrap
    self.update_period(realm, zonegroup)
  File "/lib/python3.6/site-packages/ceph/rgw/rgwam_core.py", line 514, in update_period
    period = RGWPeriod(period_info)
  File "/lib/python3.6/site-packages/ceph/rgw/types.py", line 120, in __init__
    self.realm_name = period_dict['realm_name']
KeyError: 'realm_name'

nothing else in this manager module seems to need the period's realm name, so stop trying to parse it

Fixes: https://tracker.ceph.com/issues/63783

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@cbodley
Copy link
Contributor Author

cbodley commented Dec 11, 2023

cc @adk3798 i noticed these ceph rgw realm bootstrap failures in the cephadm suite too

@adk3798
Copy link
Contributor

adk3798 commented Dec 11, 2023

cc @adk3798 i noticed these ceph rgw realm bootstrap failures in the cephadm suite too

yeah, we had https://tracker.ceph.com/issues/63499 but I hadn't looked into the cause yet. Seems like it's this.

@smanjara
Copy link
Contributor

@cbodley thanks for fixing this too.

@cbodley cbodley merged commit 7a2be8a into ceph:main Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants