rgw/kafka/amqp: fix race conditionn in async completion handlers#54697
Merged
rgw/kafka/amqp: fix race conditionn in async completion handlers#54697
Conversation
cbodley
approved these changes
Nov 28, 2023
| std::unique_ptr<Completion> completion = nullptr; | ||
| int ret; | ||
|
|
||
| mutable std::atomic<bool> done = false; |
Contributor
There was a problem hiding this comment.
it looks like we don't need atomic now that this is only accessed under lock
Fixes: https://tracker.ceph.com/issues/63314 Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
8a1798a to
3e6d527
Compare
Contributor
Author
|
teuthology passing: https://pulpito.ceph.com/yuvalif-2023-11-29_17:21:44-rgw:notifications-wip-yuval-63314-distro-default-smithi/ will run some manual tests before merging |
yuvalif
commented
Nov 29, 2023
| return amqp::publish(conn_id, topic, json_format_pubsub_event(event)); | ||
| } else { | ||
| // TODO: currently broker and routable are the same - this will require different flags but the same mechanism | ||
| // note: dynamic allocation of Waiter is needed when this is invoked from a beast coroutine |
Contributor
Author
There was a problem hiding this comment.
@cbodley seems like this comment is correct, when using a stack alocated Waiter I got a crash in the amqp test:
http://qa-proxy.ceph.com/teuthology/yuvalif-2023-11-28_20:21:18-rgw:notifications-wip-yuval-63314-distro-default-smithi/7470280/remote/smithi001/crash/posted/2023-11-28T20%3A45%3A21.487435Z_86a6d008-f8b4-4b16-915a-505ed4018929/
(not sure why)
Contributor
Author
|
done manual testing, could not reproduce crash |
This was referenced Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/63314
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e