Skip to content

cephfs_mirror: use snapdiff api for incremental syncing#54633

Merged
vshankar merged 1 commit intoceph:mainfrom
joscollin:wip-F61334-use-snapdiff-api
Mar 29, 2024
Merged

cephfs_mirror: use snapdiff api for incremental syncing#54633
vshankar merged 1 commit intoceph:mainfrom
joscollin:wip-F61334-use-snapdiff-api

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Nov 23, 2023 •
edited
Loading

Use snapdiff api to sync only the delta of files between two snapshots.

Fixes: https://tracker.ceph.com/issues/61334

@joscollin joscollin added feature cephfs Ceph File System DNM labels Nov 23, 2023
@joscollin joscollin self-assigned this Nov 23, 2023
@joscollin joscollin force-pushed the wip-F61334-use-snapdiff-api branch 2 times, most recently from f506dc9 to 90273f0 Compare November 27, 2023 12:56
@joscollin joscollin changed the title cephfs-mirror: use snapdiff api for efficient tree traversal cephfs_mirror: use snapdiff api for efficient tree traversal Nov 27, 2023
@joscollin joscollin force-pushed the wip-F61334-use-snapdiff-api branch 3 times, most recently from 2b229c5 to 59a9006 Compare December 1, 2023 10:41
@joscollin joscollin marked this pull request as ready for review December 1, 2023 10:41
@joscollin joscollin removed the DNM label Dec 1, 2023
@joscollin joscollin changed the title cephfs_mirror: use snapdiff api for efficient tree traversal cephfs_mirror: use snapdiff api for incremental syncing Dec 1, 2023
@joscollin joscollin force-pushed the wip-F61334-use-snapdiff-api branch from 59a9006 to 2af270f Compare December 4, 2023 04:07
@joscollin joscollin removed their assignment Dec 4, 2023
@joscollin joscollin force-pushed the wip-F61334-use-snapdiff-api branch from 3065ee8 to d2a5d61 Compare December 5, 2023 03:42
@joscollin
Copy link
Member Author

joscollin commented Dec 5, 2023

jenkins retest this please

@vshankar vshankar requested a review from a team December 5, 2023 13:27
vshankar
vshankar reviewed Dec 5, 2023
View reviewed changes
@joscollin joscollin force-pushed the wip-F61334-use-snapdiff-api branch from d2a5d61 to 9563d83 Compare December 6, 2023 12:43
vshankar
vshankar requested changes Dec 6, 2023
View reviewed changes
@joscollin joscollin force-pushed the wip-F61334-use-snapdiff-api branch 6 times, most recently from 9cc9423 to 369e4ec Compare December 8, 2023 11:07
@joscollin joscollin requested a review from vshankar December 8, 2023 15:40
@joscollin joscollin marked this pull request as draft December 13, 2023 03:29
@joscollin joscollin self-assigned this Dec 13, 2023
vshankar
vshankar reviewed Feb 19, 2024
View reviewed changes
@joscollin joscollin force-pushed the wip-F61334-use-snapdiff-api branch 4 times, most recently from f5e9b11 to 429d505 Compare February 22, 2024 09:03
@joscollin
Copy link
Member Author

joscollin commented Feb 22, 2024

@vshankar This is ready for your review.

@joscollin joscollin requested a review from vshankar February 22, 2024 09:26
@joscollin
Copy link
Member Author

joscollin commented Feb 26, 2024

jenkins test make check

@vshankar
Copy link
Contributor

vshankar commented Feb 26, 2024

@vshankar This is ready for your review.

Thx for the update - I'll have a look today.

@joscollin
cephfs_mirror: use snapdiff api for incremental syncing
96c351c 
Use snapdiff api to sync only the delta of files between two snapshots.

Fixes: https://tracker.ceph.com/issues/61334
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin joscollin force-pushed the wip-F61334-use-snapdiff-api branch from 429d505 to 96c351c Compare February 26, 2024 05:52
@vshankar
Copy link
Contributor

vshankar commented Mar 11, 2024

https://pulpito.ceph.com/?branch=wip-vshankar-testing-20240307.013758

(test run review pending)

@joscollin
Copy link
Member Author

joscollin commented Mar 11, 2024

https://pulpito.ceph.com/?branch=wip-vshankar-testing-20240307.013758

(test run review pending)

In these tests:
http://qa-proxy.ceph.com/teuthology/vshankar-2024-03-07_10:36:38-fs-wip-vshankar-testing-20240307.013758-testing-default-smithi/7584432/teuthology.log
http://qa-proxy.ceph.com/teuthology/vshankar-2024-03-07_10:36:38-fs-wip-vshankar-testing-20240307.013758-testing-default-smithi/7584441/teuthology.log

test_cephfs_mirror_incremental_sync shows failed status.
This doesn't fail the incremental syncing by do_synchronize(). It fails the checksum of the first snapshot syncing only and happens intermittently. So this should be an intermittent failure as mentioned here [1]. For a trial, just change the order of these tests, and all passes.

test_cephfs_mirror_cancel_mirroring_and_readd shows failed status.
It's obviously not a mirror sync failure. The command 'ceph --admin-daemon /var/run/ceph/cephfs-mirror.asok counter dump' failed in remove_directory().

[1] https://tracker.ceph.com/issues/64534

@vshankar
Copy link
Contributor

vshankar commented Mar 19, 2024

https://pulpito.ceph.com/?branch=wip-vshankar-testing-20240307.013758
(test run review pending)

In these tests: http://qa-proxy.ceph.com/teuthology/vshankar-2024-03-07_10:36:38-fs-wip-vshankar-testing-20240307.013758-testing-default-smithi/7584432/teuthology.log http://qa-proxy.ceph.com/teuthology/vshankar-2024-03-07_10:36:38-fs-wip-vshankar-testing-20240307.013758-testing-default-smithi/7584441/teuthology.log

test_cephfs_mirror_incremental_sync shows failed status. This doesn't fail the incremental syncing by do_synchronize(). It fails the checksum of the first snapshot syncing only and happens intermittently. So this should be an intermittent failure as mentioned here [1]. For a trial, just change the order of these tests, and all passes.

test_cephfs_mirror_cancel_mirroring_and_readd shows failed status. It's obviously not a mirror sync failure. The command 'ceph --admin-daemon /var/run/ceph/cephfs-mirror.asok counter dump' failed in remove_directory().

[1] https://tracker.ceph.com/issues/64534

https://tracker.ceph.com/issues/64534#note-3

@joscollin
Copy link
Member Author

joscollin commented Mar 20, 2024

https://pulpito.ceph.com/?branch=wip-vshankar-testing-20240307.013758
(test run review pending)

In these tests: http://qa-proxy.ceph.com/teuthology/vshankar-2024-03-07_10:36:38-fs-wip-vshankar-testing-20240307.013758-testing-default-smithi/7584432/teuthology.log http://qa-proxy.ceph.com/teuthology/vshankar-2024-03-07_10:36:38-fs-wip-vshankar-testing-20240307.013758-testing-default-smithi/7584441/teuthology.log
test_cephfs_mirror_incremental_sync shows failed status. This doesn't fail the incremental syncing by do_synchronize(). It fails the checksum of the first snapshot syncing only and happens intermittently. So this should be an intermittent failure as mentioned here [1]. For a trial, just change the order of these tests, and all passes.
test_cephfs_mirror_cancel_mirroring_and_readd shows failed status. It's obviously not a mirror sync failure. The command 'ceph --admin-daemon /var/run/ceph/cephfs-mirror.asok counter dump' failed in remove_directory().
[1] https://tracker.ceph.com/issues/64534

https://tracker.ceph.com/issues/64534#note-3

@vshankar updated the tracker.

vshankar
vshankar approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @joscollin

@joscollin
Copy link
Member Author

joscollin commented Mar 26, 2024

Nice work @joscollin

Thanks.

@vshankar vshankar merged commit e2d3bf8 into ceph:main Mar 29, 2024
@joscollin joscollin deleted the wip-F61334-use-snapdiff-api branch March 29, 2024 06:08
This was referenced Aug 1, 2024
Merged
Open
sajibreadd
sajibreadd reviewed Dec 6, 2024
View reviewed changes
@joscollin joscollin mentioned this pull request Dec 16, 2024
Closed
14 tasks
@joscollin joscollin mentioned this pull request Feb 24, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@sajibreadd sajibreadd sajibreadd left review comments

@gregsfortytwo gregsfortytwo Awaiting requested review from gregsfortytwo

Assignees

No one assigned

Labels

cephfs Ceph File System feature tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joscollin @vshankar @sajibreadd