Conversation
fde0174 to
d1d4481
Compare
rzarzynski
approved these changes
Nov 9, 2023
Contributor
rzarzynski
left a comment
There was a problem hiding this comment.
LGTM!
Two typos found in the commit msg:
is empalced into subop_blocker.
Stroing the operation as a reference instead of the id
cyx1231st
approved these changes
Nov 10, 2023
The operation's id and future returned when starting SnapTrimObjSubEvent is emplaced into subop_blocker. Later on, we await the completion of all the started operations futures. Before this patch, we only stored the op id in the subop_blocker vector which allowed `op` to go out of scope and lose all its references (and get deleted) before exiting. Storing the operation as a reference instead of the id will maintain the SnapTrimObjSubEvent operation lifetime. Fixes: https://tracker.ceph.com/issues/63299 Signed-off-by: Matan Breizman <mbreizma@redhat.com>
d1d4481 to
c9d1f28
Compare
Contributor
Author
|
https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-testing-11-12-v2/ Failures, unrelated: 7456908 - 7456917 - infra |
athanatos
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operation's id and future returned when starting SnapTrimObjSubEvent
is empalced into subop_blocker.
Later on, we await the completion of all the started operations futures.
Before this patch, we only stored the op id in the subop_blocker vector
which allowed
opto go out of scope and lose all its references(and get deleted) before exiting.
Storing the operation as a reference instead of the id
will maintain the SnapTrimObjSubEvent operation lifetime.
Fixes: https://tracker.ceph.com/issues/63299
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e