crimson/osd/pg: do_osd_ops_execute refactor#54040
Merged
Conversation
c588203 to
6f93b8e
Compare
add verbosity around returned futures, no change in behavior. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
be more explicit around returned futures, no change in behavior. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
6f93b8e to
5001336
Compare
rzarzynski
reviewed
Oct 19, 2023
Contributor
rzarzynski
left a comment
There was a problem hiding this comment.
Overall looks good. One question.
| seastar::make_lw_shared<OpsExecuter>( | ||
| Ref<PG>{this}, obc, op_info, *m, conn, snapc), | ||
| m->ops, | ||
| // success_func |
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
5001336 to
dd5c18a
Compare
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Contributor
Author
|
jenkins retest this please |
athanatos
approved these changes
Oct 25, 2023
This was referenced Oct 30, 2023
cyx1231st
reviewed
Nov 1, 2023
Member
cyx1231st
left a comment
There was a problem hiding this comment.
LGTM, looks the behavior is unchanged, so probably worth adding keyword "cleanup" to the PR title?
14 tasks
Contributor
Author
Yes, no behavior change. "Refactor" was added to the title, I'll add cleanup label as well. Thanks! Merging based on tests. failures: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary refactor around
do_osd_ops_execute()in preparation for: https://tracker.ceph.com/issues/61651.Mainly for separating the two returned futures (
submittedandall_completed).Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows