client: two fix for checking mds auth access in client side#53887
Merged
rishabh-d-dave merged 2 commits intoceph:mainfrom Nov 7, 2023
Merged
client: two fix for checking mds auth access in client side#53887rishabh-d-dave merged 2 commits intoceph:mainfrom
rishabh-d-dave merged 2 commits intoceph:mainfrom
Conversation
gregsfortytwo
requested changes
Oct 13, 2023
Member
gregsfortytwo
left a comment
There was a problem hiding this comment.
Let's adjust which code includes the mount point in the path string.
I would really like to be able to export the make_path_string() symbol via libcephfs for consumption, but we don't need to make it that robust right now.
The mountpoint's root ino# possibly not be the full CephFS filesystem root, it's just the mountpoint of this particular client. Just prepend the mountpoint path to the full path. Introduced-by: c1bf8d8 client: check the cephx mds auth access for setattr Introduced-by: ce21659 client: check the cephx mds auth access for open Fixes: ceph#48027 (comment) Signed-off-by: Xiubo Li <xiubli@redhat.com>
Just in case we cannot link all the way to our mount point we will force to do sync requests instead and let the MDS do the auth access check. Introduced-by: fd7aaab client: add make_path_string() helpers support Fixes: ceph#48027 (comment) Signed-off-by: Xiubo Li <xiubli@redhat.com>
53b2e08 to
c7bc452
Compare
rishabh-d-dave
approved these changes
Nov 7, 2023
Contributor
rishabh-d-dave
left a comment
There was a problem hiding this comment.
CephFS integration tests were successful - https://tracker.ceph.com/projects/cephfs/wiki/Main#7-Nov-2023
This was referenced Nov 13, 2023
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #48027 (comment)
Fixes: #48027 (comment)
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows