Skip to content

mgr/dashboard: start using alertmanager v2#53679

Merged
aaSharma14 merged 1 commit intoceph:mainfrom
rhcs-dashboard:alerts-v2-api
Apr 2, 2024
Merged

mgr/dashboard: start using alertmanager v2#53679
aaSharma14 merged 1 commit intoceph:mainfrom
rhcs-dashboard:alerts-v2-api

Conversation

@nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Sep 26, 2023 •
edited by aaSharma14
Loading

I was looking into sorting the alerts and saw there is an api v2 for alertmanager which also has an endpoint like alerts/groups which might be something that is useful for us.

Fixes: https://tracker.ceph.com/issues/65070

Refer: https://github.com/prometheus/alertmanager/blob/main/api/v2/openapi.yaml

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@nizamial09 nizamial09 mentioned this pull request Sep 26, 2023
Merged
14 tasks
@github-actions
Copy link

github-actions bot commented Jan 3, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jan 3, 2024
@github-actions
Copy link

github-actions bot commented Feb 2, 2024

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Feb 2, 2024
@nizamial09 nizamial09 reopened this Mar 21, 2024
@nizamial09 nizamial09 mentioned this pull request Mar 21, 2024
Merged
14 tasks
@github-actions github-actions bot removed the stale label Mar 21, 2024
@nizamial09 nizamial09 marked this pull request as ready for review March 22, 2024 09:52
@nizamial09 nizamial09 requested a review from a team as a code owner March 22, 2024 09:52
@nizamial09 nizamial09 requested review from Pegonzal and cloudbehl and removed request for a team March 22, 2024 09:52
@nizamial09 nizamial09 force-pushed the alerts-v2-api branch 2 times, most recently from 4d57bb4 to a15206a Compare March 25, 2024 04:57
@nizamial09
mgr/dashboard: start using alertmanager v2
6f2d0b1 
I was looking into sorting the alerts and saw there is an api v2 for
alertmanager which also has an endpoint like `alerts/groups` which might
be something that is useful for us.

Refer: https://github.com/prometheus/alertmanager/blob/main/api/v2/openapi.yaml

Fixes: https://tracker.ceph.com/issues/65070
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09
Copy link
Member Author

nizamial09 commented Mar 27, 2024

jenkins test api

@nizamial09
Copy link
Member Author

nizamial09 commented Mar 27, 2024

jenkins test make check

@nizamial09
Copy link
Member Author

nizamial09 commented Mar 27, 2024

jenkins test dashboard cephadm

1 similar comment
@nizamial09
Copy link
Member Author

nizamial09 commented Mar 29, 2024

jenkins test dashboard cephadm

@cloudbehl cloudbehl mentioned this pull request Apr 1, 2024
Merged
14 tasks
aaSharma14
aaSharma14 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@aaSharma14 aaSharma14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @nizamial09

@aaSharma14 aaSharma14 merged commit 107e162 into ceph:main Apr 2, 2024
@aaSharma14 aaSharma14 deleted the alerts-v2-api branch April 2, 2024 04:22
@nizamial09 nizamial09 mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaSharma14 aaSharma14 aaSharma14 approved these changes

@cloudbehl cloudbehl Awaiting requested review from cloudbehl cloudbehl is a code owner automatically assigned from ceph/dashboard

@Pegonzal Pegonzal Awaiting requested review from Pegonzal Pegonzal is a code owner automatically assigned from ceph/dashboard

Assignees

No one assigned

Labels

api-change dashboard pybind

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nizamial09 @aaSharma14