Skip to content

qa/cephfs: add back POOL_APP_NOT_ENABLED to ignorelist (partial revert)#53331

Merged
batrick merged 1 commit intomainfrom
revert-53037-i62482
Sep 9, 2023
Merged

qa/cephfs: add back POOL_APP_NOT_ENABLED to ignorelist (partial revert)#53331
batrick merged 1 commit intomainfrom
revert-53037-i62482

Conversation

@vshankar
Copy link
Contributor

@vshankar vshankar commented Sep 8, 2023 •
edited
Loading

Partially reverts #53037

@vshankar vshankar added the cephfs Ceph File System label Sep 8, 2023
@vshankar vshankar requested review from a team, batrick and idryomov September 8, 2023 07:08
@vshankar vshankar force-pushed the revert-53037-i62482 branch from b837d73 to 21dfe28 Compare September 8, 2023 07:12
idryomov
idryomov reviewed Sep 8, 2023
View reviewed changes
@vshankar vshankar force-pushed the revert-53037-i62482 branch from 21dfe28 to a0e5379 Compare September 8, 2023 08:42
@vshankar vshankar changed the title Revert "qa: do not create rbd pool for CephFS QA" qa/cephfs: add back POOL_APP_NOT_ENABLED to ignorelist (partial revert) Sep 8, 2023
@vshankar
Revert "Revert "Merge PR #53077 into main""
7d5795d 
This reverts commit af4558f.

Fixes: http://tracker.ceph.com/issues/62482
Signed-off-by: Venky Shankar <vshankar@redhat.com>
@vshankar vshankar force-pushed the revert-53037-i62482 branch from a0e5379 to 7d5795d Compare September 8, 2023 08:46
@vshankar vshankar requested a review from idryomov September 8, 2023 09:24
idryomov
idryomov approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know @batrick would rather see a revert of #47560 and I brought up the same on the dev list, although for different reasons. @batrick appears to want to this health alert to be disabled in testing universally rather than in each suite individually, whereas I maintain that the health alert itself should be fixed so that it "behaves" for regular users/operators too:

It shouldn't be just developers running their tests with a special knob set who get the sane behavior.

Alas, neither of us has gotten much traction...

@vshankar
Copy link
Contributor Author

vshankar commented Sep 8, 2023

I know @batrick would rather see a revert of #47560 and I brought up the same on the dev list, although for different reasons. @batrick appears to want to this health alert to be disabled in testing universally rather than in each suite individually,

I should have mentioned here that in stand-up, a couple of days back, @batrick agreed to move forward with the revert of the revert (this change) till discussions reach a conclusion on #47560.

@batrick
Copy link
Member

batrick commented Sep 8, 2023

#53336

@batrick batrick merged commit 7264120 into main Sep 9, 2023
@batrick batrick deleted the revert-53037-i62482 branch September 9, 2023 14:50
@vshankar vshankar mentioned this pull request Oct 6, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

@idryomov idryomov idryomov approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vshankar @batrick @idryomov