Skip to content

rgw/multisite: fixes assertion failure during realm reload#53045

Merged
cbodley merged 1 commit intoceph:mainfrom
smanjara:wip-shilpa-revert-51772
Sep 21, 2023
Merged

rgw/multisite: fixes assertion failure during realm reload#53045
cbodley merged 1 commit intoceph:mainfrom
smanjara:wip-shilpa-revert-51772

Conversation

@smanjara
Copy link
Contributor

@smanjara smanjara commented Aug 17, 2023

This reverts commit 30cbf66.

https://tracker.ceph.com/issues/62298

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@smanjara smanjara requested a review from a team as a code owner August 17, 2023 19:25
@github-actions github-actions bot added the rgw label Aug 17, 2023
@cbodley
Copy link
Contributor

cbodley commented Aug 17, 2023

thanks @smanjara. revert commits need your signed-off-by too

@smanjara
Copy link
Contributor Author

smanjara commented Aug 17, 2023

the changes from #51772 inadvertently introduced a bug in RGWRemoteDataLog::finish() , where invoking http_manager stop() before calling RGWCoroutinesManager::stop() prevented the completion notifiers from shutting down correctly. The backtrace can be found in the tracker attached.

@caisan I haven't been able to reproduce the original issue you have described in #51772. Please consider adding reproducer steps to the pr along with debug enabled logs, so we can try to find a solution for it.

Revert "rgw:multisite hang when update and commit period"
d3939de 
This reverts commit 30cbf66.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
@smanjara smanjara force-pushed the wip-shilpa-revert-51772 branch from d6ddc1b to d3939de Compare August 17, 2023 19:43
@cbodley
Copy link
Contributor

cbodley commented Sep 14, 2023

jenkins test api

@cbodley
Copy link
Contributor

cbodley commented Sep 21, 2023

jenkins test api

@cbodley
Copy link
Contributor

cbodley commented Sep 21, 2023

passed qa in https://pulpito.ceph.com/cbodley-2023-09-20_13:28:54-rgw-wip-cbodley-testing-distro-default-smithi/; multisite tests failed but didn't crash

@cbodley
Copy link
Contributor

cbodley commented Sep 21, 2023

good to merge once checks pass

@cbodley
Copy link
Contributor

cbodley commented Sep 21, 2023

jenkins test api

@cbodley cbodley merged commit 70973ad into ceph:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

No one assigned

Labels

ready-to-merge rgw TESTED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smanjara @cbodley