os/bluestore/unittest_alloc_aging: Updated#52830
Conversation
Fixed compilation after Allocator interface update. Added "hybrid" to the list. Now accepts ceph command line parameters. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Now added consistency check for free extents returned by Allocator. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
|
jenkins test api |
1 similar comment
|
jenkins test api |
| << "] vs [0x" << it->first << "-" << it->first + it->second | ||
| << "]" << std::dec << std::endl; | ||
| if (end > it->first + it->second) { | ||
| // this new extent spans further then previous one, take it |
There was a problem hiding this comment.
IMO the condition above means that old(!) extents spans further not the new one. So you might want to switch these 'if' branches
| } | ||
| } | ||
| } | ||
| //3. Check total capacity |
There was a problem hiding this comment.
I believe this checking can be performed at step 2. as well.
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
Fixed compilation after Allocator interface update.
Added "hybrid" to the list.
Now accepts ceph command line parameters.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows