pacific: qa: pass arg as list to fix test case failure#52763
Merged
yuriw merged 1 commit intoceph:pacificfrom Dec 5, 2023
Merged
pacific: qa: pass arg as list to fix test case failure#52763yuriw merged 1 commit intoceph:pacificfrom
yuriw merged 1 commit intoceph:pacificfrom
Conversation
Contributor
|
jenkins test make check |
Contributor
|
jenkins test api |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test api |
vshankar
previously approved these changes
Aug 11, 2023
Contributor
|
https://pulpito.ceph.com/?branch=wip-yuri8-testing-2023-08-11-0834-pacific Failures, related:
Details:
|
Contributor
|
@dparmar18 Tracker#62450 is related to this PR. Kindly look into it. |
Pacific branch's run_cluster_cmd() code can't split string into a list, and because backporting is too tricky as a lot of qa code doesn't reach pacific, it would be tedious to backport the PRs that enabled passing string as arg to run_cluster_cmd() in ceph_manager.py. For complete details please checkout note #13 in the tracker attached below. Fixes: https://tracker.ceph.com/issues/61732 Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
Contributor
Author
can you re-run this please, should be fixed |
batrick
previously requested changes
Aug 17, 2023
Member
batrick
left a comment
There was a problem hiding this comment.
https://tracker.ceph.com/projects/cephfs/wiki/Pacific#2023-August-11
Leaving request changes so this isn't merged by accident. I see @dparmar18 has already amended the PR with a fix.
Contributor
|
Looks good to me. The test passed with the fix. |
kotreshhr
approved these changes
Dec 5, 2023
Contributor
|
@dparmar18 @batrick this PR passed tests and can be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pacific branch's run_cluster_cmd() code can't split string into a list, and
because backporting is too tricky as a lot of qa code doesn't reach pacific, it
would be tedious to backport the PRs that enabled passing string as arg to
run_cluster_cmd() in ceph_manager.py. For complete details please checkout
note #13 in the tracker attached below
Fixes: https://tracker.ceph.com/issues/61732
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows