qa/cephfs: fix test_disallow_monitor_managed_snaps_for_fs_pools#52709
Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom Aug 2, 2023
Merged
qa/cephfs: fix test_disallow_monitor_managed_snaps_for_fs_pools#52709rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave merged 1 commit intoceph:mainfrom
Conversation
run_cluster_cmd() method is not available anymore because it was deleted here on this PR - https://github.com/ceph/ceph/pull/50569/files#diff-1c6c246ba42f343603d7174198dd1fb9c2654b6c883594d1a0891096b7a35875L408 Fixes: https://tracker.ceph.com/issues/62243 Signed-off-by: Rishabh Dave <ridave@redhat.com>
vshankar
approved these changes
Aug 1, 2023
Contributor
|
jenkins retest this please |
dparmar18
approved these changes
Aug 1, 2023
Contributor
|
@rishabh-d-dave I guess this is ready to merge? |
Contributor
Author
|
@vshankar Yes. This PR is ready for merge now since the test ran successfully and |
Contributor
Author
|
Just for record: this bug fixed on this PR was introduced on PR #50569. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_cluster_cmd() method is not available anymore because it was deleted
here on this PR -
https://github.com/ceph/ceph/pull/50569/files#diff-1c6c246ba42f343603d7174198dd1fb9c2654b6c883594d1a0891096b7a35875L408
Fixes: https://tracker.ceph.com/issues/62243
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows