mds: defer trim() until after the last cache_rejoin ack being received#52648
mds: defer trim() until after the last cache_rejoin ack being received#52648rishabh-d-dave merged 1 commit intoceph:mainfrom
Conversation
27a5b63 to
7db99a7
Compare
batrick
left a comment
There was a problem hiding this comment.
Let's move mds: remove unused C_MDC_OpenSnapRealms to another PR.
Rest looks good to me but I think you forgot to add MDCache.h changes?
Sure.
Yeah, still in the stash. |
@rishabh-d-dave Please include it in your next integration run. |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
@lxbsz Please rebase and let me know, I'll put it through QA. |
Just before the last cache_rejoin ack being received the entire subtree, together with the inode subtree root belongs to, were trimmed the isolated_inodes list couldn't be correctly erased. We should defer calling the trim() until the last cache_rejoin ack being received. Fixes: https://tracker.ceph.com/issues/62036 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Done. Thanks. |
rishabh-d-dave
left a comment
There was a problem hiding this comment.
I had to do multiple QA runs and re-runs due to build issues (due to one of the PRs in testing branch), unrelated issues in FS test suite, unrelated issues in testing kernel and new failures in every run that needed to ensured that they were unrelated to PRs in testing branch.
I finally have a run that is better than others - https://tracker.ceph.com/projects/cephfs/wiki/Main#4-Apr-2024. Sorry for the delay.
Just before the last cache_rejoin ack being received the entire subtree, together with the inode subtree root belongs to, were trimmed the isolated_inodes list couldn't be correctly erased. We should defer calling the trim() until the last cache_rejoin ack being received.
Fixes: https://tracker.ceph.com/issues/62036
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows