quincy: mds: allow all types of mds caps#52582
quincy: mds: allow all types of mds caps#52582rishabh-d-dave wants to merge 3 commits intoceph:quincyfrom
Conversation
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
MDS caps can contain 5 components: name of a CephFS, a path inside CephFS, a flag for enabling root squashing mechanism, a UID and list of GIDs. These 5 components result in 31 combinations, so there can be 31 types of MDS caps. Out of these, the current main branch only allows 11 combinations. This restriction is strange and inappropriate. Ideally, all combinations should be allowed. This strange restriction must've been created unintentionally by previous developers while adding FS name and root squash to MDS caps. A TODO for a allowing a subset of these combination was also left in codebase: https://github.com/ceph/ceph/blob/reef/src/mds/MDSAuthCaps.cc#L69 Fixes: https://tracker.ceph.com/issues/59388 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 0c36929) Conflicts: src/mds/MDSAuthCaps.cc - Unlike main branch, on Quincy branch, MDSAuthCaps calls string by writing std::string instead of just string.
Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 248e9da) Conflicts: src/test/mds/TestMDSAuthCaps.cc - Unlike main branch, on Quincy branch, MDSAuthCaps::parse() method accepts instance of class CephContext as an argument.
Currently we check if the right caps parse successfully and the wrong caps fail to parse. Increase the test coverage by adding one more tests -- dump the right caps in to a string after the parsing is successfully and then re-parse the caps and check if re-parsed caps dumps to the exact same string. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit bfacee1)
8ab3a15 to
1ff6bc6
Compare
|
@rishabh-d-dave could you check on make check failure? |
|
make check job logs are not available - https://jenkins.ceph.com/job/ceph-pull-requests/129456/ |
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
|
This PR is under test in https://tracker.ceph.com/issues/67315. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
@vshankar Any update about the QA run for this PR? |
|
This PR is under test in https://tracker.ceph.com/issues/69400. |
|
@rishabh-d-dave Please help me recall if there was a bug that got introduced due to this change (in main) and those commits need to be additionally backported. Would you know? |
|
Quincy is EOL. |
backport tracker: https://tracker.ceph.com/issues/62027
backport of #51317
parent tracker: https://tracker.ceph.com/issues/59388
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh