Skip to content

reef: install-deps: remove the legacy resolver flags#52562

Merged
ljflores merged 1 commit intoceph:reeffrom
rhcs-dashboard:reef-make-check-fix
Jul 20, 2023
Merged

reef: install-deps: remove the legacy resolver flags#52562
ljflores merged 1 commit intoceph:reeffrom
rhcs-dashboard:reef-make-check-fix

Conversation

@nizamial09
Copy link
Member

Backport of #52544

This was a workaround that was introduced long time ago. This will be something that could be deprectaed at some point [1]. And its preventing some of the dependencies to be downloaded or stored into the wheelhouse. Deps like jsonschema, parse, mypy, cryptography etc.

[1] https://pip.pypa.io/en/latest/user_guide/#deprecation-timeline

Fixes: https://tracker.ceph.com/issues/62082
Signed-off-by: Nizamudeen A nia@redhat.com
(cherry picked from commit d179b95)

Conflicts:
install-deps.sh

  • discard the incoming change and edit the line manually

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

This was a workaround that was introduced long time ago. This will be
something that could be deprectaed at some point [1]. And its preventing some of the dependencies to be
downloaded or stored into the wheelhouse. Deps like jsonschema, parse,
mypy, cryptography etc.

[1] https://pip.pypa.io/en/latest/user_guide/#deprecation-timeline

Fixes: https://tracker.ceph.com/issues/62082
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit d179b95)

 Conflicts:
	install-deps.sh
  - discard the incoming change and edit the line manually
@nizamial09 nizamial09 requested a review from ljflores July 20, 2023 17:31
@github-actions github-actions bot added this to the reef milestone Jul 20, 2023
@ljflores ljflores merged commit b9c94e4 into ceph:reef Jul 20, 2023
@ljflores
Copy link
Member

Thanks @nizamial09!

@nizamial09 nizamial09 deleted the reef-make-check-fix branch July 21, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants