install-deps.sh: remove line that updates pip#52558
install-deps.sh: remove line that updates pip#52558
Conversation
5b06d59 to
2fd0b0f
Compare
Somehow, updating pip causes packages to go missing in various generated /wheelhouse folders. Fixes: https://tracker.ceph.com/issues/62082 Signed-off-by: Laura <lflores@redhat.com>
2fd0b0f to
adc389b
Compare
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
jenkins test api |
| type python3 > /dev/null 2>&1 || continue | ||
| activate_virtualenv $top_srcdir || exit 1 | ||
| python3 -m pip install --upgrade pip | ||
| # python3 -m pip install --upgrade pip |
There was a problem hiding this comment.
not sure whether its a good idea to stop pip from upgrading. Maybe pinning it to 22.02 rather than stopping it? Also when newer python versions are applied to project, we might need new pip to pull in the new dependencies which might be unsupported by older pip versions. But I am not a best person to speak for python. I'll let other people to decide.
We are also updating pip in the src/tools/setup-venv.sh file. So I guess we are limitting it while on the install-deps only and this causes differences between the versions while installing install-deps deps and tox deps.
There was a problem hiding this comment.
Maybe pinning it to
22.02rather than stopping it?
Do we know what changed after that release?
Also when newer python versions are applied to project, we might need new pip to pull in the new dependencies which might be unsupported by older pip versions.
Exactly. This is why I like #52544 better.
There was a problem hiding this comment.
This is why I like #52544 better.
It also gets rid of "fast-deps has no effect when used with the legacy resolver" warnings.
There was a problem hiding this comment.
Do we know what changed after that release?
I couldn't find why this changed suddenly. But looks like there have been so many deprecations or changes happening with the legacy versions on some of the latest pip releases
There was a problem hiding this comment.
I also prefer to fix this problem for the newest pip, but we may also want to pin it to a specific major version (something like >=23,<24 IIRC) so that as long as pip is well behaved and don't make big behavior changes in minor versions we get the benefit of taking fixes but not getting surprised by major version changes. It just requires some discipline to periodically check that there's a new major version and then update+test.
There was a problem hiding this comment.
Here it broke with a minor version: 23.2 was released five days ago, the issue popped up immediately after that. I didn't dig deeper but it seems to be too close to be just a coincidence.
There was a problem hiding this comment.
OK, I missed that. I had thought the behavior change was going from 22.x to 23.x, thanks for the update.
|
Closing in favor of #52544. Thanks @nizamial09 ! |
This came from the new release of pip on July 15th: https://pypi.org/project/pip/23.2/
Keeping pip at v22.0.2 is what is helping the tests pass for now.
Fixes: https://tracker.ceph.com/issues/62082
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows