Skip to content

reef: mon: block osd pool mksnap for fs pools#52399

Merged
yuriw merged 2 commits intoceph:reeffrom
mchangir:wip-61959-reef
Jul 19, 2023
Merged

reef: mon: block osd pool mksnap for fs pools#52399
yuriw merged 2 commits intoceph:reeffrom
mchangir:wip-61959-reef

Conversation

@mchangir
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/61959


backport of #51275
parent tracker: https://tracker.ceph.com/issues/59552

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

mchangir added 2 commits July 11, 2023 21:37
Commit 23db15d disabled pool snaps for the rados mksnap path. But
ceph osd pool mksnap was an alternate way that pool snaps could be
created.
This commit disables pool snaps via this alternate path as well.

NOTE:
Pool-level snaps and fs-level snaps can't co-exist since snap IDs are
likely to clash between the two different mechanisms and can result in
unintentional data loss when either of the snaps are deleted.

Fixes: https://tracker.ceph.com/issues/59552
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 6203fe1)
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit ab64bfa)
@mchangir mchangir requested a review from a team as a code owner July 11, 2023 16:07
@mchangir mchangir added this to the reef milestone Jul 11, 2023
@mchangir mchangir added the core label Jul 11, 2023
@github-actions github-actions bot added cephfs Ceph File System mon tests labels Jul 11, 2023
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar
Copy link
Contributor

@rzarzynski PTAL.

(fs suite run is fine)

@yuriw yuriw merged commit f54e3bc into ceph:reef Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants