Skip to content

test/rgw: annotating variables with maybe_unused#52315

Merged
cbodley merged 1 commit intoceph:mainfrom
ronen-fr:wip-rf-rgw-tasserts
Jan 8, 2024
Merged

test/rgw: annotating variables with maybe_unused#52315
cbodley merged 1 commit intoceph:mainfrom
ronen-fr:wip-rf-rgw-tasserts

Conversation

@ronen-fr
Copy link
Contributor

@ronen-fr ronen-fr commented Jul 5, 2023

Some variables in test/rgw/rgw_cr_test.cc are only used in asserts,
while this file is also used in builds without NDEBUG set (why?).

Adding the [[maybe_unused]] attribute clears the compilation warnings.

@ronen-fr
test/rgw: annotating variables with maybe_unused
25890a2 
Some variables in test/rgw/rgw_cr_test.cc are only used in
asserts, while this file is also used in builds without
NDEBUG set.
Adding the [[maybe_unused]] attribute clears the compilation
warnings.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
@ronen-fr ronen-fr requested a review from a team as a code owner July 5, 2023 11:06
@ceph ceph deleted a comment from ljflores Jul 6, 2023
@ronen-fr
Copy link
Contributor Author

ronen-fr commented Jul 10, 2023

jenkins test api

@dang
Copy link
Contributor

dang commented Jul 10, 2023

Do these warnings only show up if you're not building in developer mode?

@mkogan1 mkogan1 requested review from cbodley, dang and mattbenjamin July 10, 2023 14:40
@ronen-fr
Copy link
Contributor Author

ronen-fr commented Jul 10, 2023

Do these warnings only show up if you're not building in developer mode?

I am building with 'relwithdebinfo'

@ronen-fr
Copy link
Contributor Author

ronen-fr commented Jul 22, 2023

@dang , @mattbenjamin - to mention one more detail: I am encountering this when building the tests
(ninja tests).
Can it be approved?

@ronen-fr
Copy link
Contributor Author

ronen-fr commented Aug 9, 2023

@dang , @mattbenjamin - ping?

@github-actions
Copy link

github-actions bot commented Nov 9, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 9, 2023
@thotz thotz removed the stale label Nov 9, 2023
@thotz thotz requested a review from kalebskeithley November 9, 2023 12:22
@github-actions
Copy link

github-actions bot commented Jan 8, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jan 8, 2024
@cbodley
Copy link
Contributor

cbodley commented Jan 8, 2024

jenkins test this please

mattbenjamin
mattbenjamin reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems harmless

@cbodley cbodley merged commit 5a5ca59 into ceph:main Jan 8, 2024
@cbodley
Copy link
Contributor

cbodley commented Jan 8, 2024

thanks @ronen-fr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattbenjamin mattbenjamin mattbenjamin left review comments

@cbodley cbodley cbodley approved these changes

@dang dang Awaiting requested review from dang

@kalebskeithley kalebskeithley Awaiting requested review from kalebskeithley

Assignees

No one assigned

Labels

cleanup ready-to-merge rgw tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronen-fr @dang @cbodley @mattbenjamin @thotz