mgr/dashboard: CephFS statfs REST API#52218
Conversation
|
For example: |
|
Hi @cloudbehl have a code review |
|
@dparmar18 help me code review if you have time |
|
Would be good to have a feature tracker for this |
|
We have Did you check if the "additional information" mentioned contains bytes/files usage stats? |
|
If we decide to move with this patch then we need to verify that this works as intended, I'm unsure how dashboard tests works but definitely we need a test case here. |
|
ls_dir statfs |
I have not found a test case about ls_dir, get quota and set quota, should we write a test case for these API in another PR? |
Interesting; usually it's always a good idea to test whatever code is being added. I'm surprised ls_dir and other stuff isn't tested. |
37bd667 to
1d98985
Compare
|
@dparmar18 updated: |
I think just |
at this point i think we can just mimic this #52218 (comment) and keep it as simple as |
|
@YiteGu i think just "bytes" instead of "used_bytes" would be better IMO just like what we have in rstat |
|
It's usually good to cleanup the changes made in a test case; you add some files to the fs; i think you should also make sure to delete them upon exit |
|
some doc failures |
a5adc8f to
63d9ec4
Compare
We don't seem to have an API for delete a file yet |
63d9ec4 to
62cd4ed
Compare
you can use |
got it |
62cd4ed to
85d0f10
Compare
85d0f10 to
8478c29
Compare
|
Hi, @nizamial09 help me check this make check fail about run_tox_mgr_dashboard_openapi :) |
|
From make check log |
you can generate a new openapi spec using the command |
dd5dd1e to
ea38205
Compare
make check completed |
|
jenkins test dashboard cephadm |
nizamial09
left a comment
There was a problem hiding this comment.
Thanks for addressing all the comments @YiteGu
one more thing: you'll need to attach the tracker to the commit with a fixes message.
Fixes: <tracker-url>
Introduce statfs for the CephFS REST API controller, we can easily get statfs of the specified path by it, it returns the used bytes, used files and used subdirs. Fixes: https://tracker.ceph.com/issues/61883 Signed-off-by: Yite Gu <yitegu0@gmail.com>
ea38205 to
bcbf91d
Compare
|
fixes message done |
|
jenkins test make check |
|
jenkins test windows |
|
thank you @YiteGu |
|
@YiteGu should this be backported to reef and quincy? if so can you update the tracker? https://tracker.ceph.com/issues/61883 |
|
Introduce statfs for the CephFS REST API controller, we can get statfs of the specified path by it, it returns the used bytes and the number of files used.
Fixes: https://tracker.ceph.com/issues/61883
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows