client: force sending cap revoke ack always#52175
Merged
Conversation
kotreshhr
reviewed
Jun 26, 2023
Contributor
kotreshhr
left a comment
There was a problem hiding this comment.
Changes look good but the timeout in the test happened because of this ?
Member
Author
Yeah, it is. |
batrick
requested changes
Jun 26, 2023
batrick
approved these changes
Jun 27, 2023
Member
batrick
left a comment
There was a problem hiding this comment.
Does the kernel also have this problem?
Member
Author
Yeah, I have fixed it too and Cced you. The patchwork link: https://patchwork.kernel.org/project/ceph-devel/patch/20230627070101.170876-1-xiubli@redhat.com/. Thanks. |
vshankar
reviewed
Jun 28, 2023
If just before the revoke request, which will increase the 'seq', is sent out the clients released the corresponding caps and sent out the cap update request with old 'seq', the mds will miss checking the seqs and calculating the caps. We should always send an ack for revoke requests. Fixes: https://tracker.ceph.com/issues/61782 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Contributor
|
jenkins test windows |
Contributor
Contributor
|
jenkins test windows |
vshankar
approved these changes
Jul 13, 2023
This was referenced Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If just before the revoke request, which will increase the 'seq', is
sent out the clients released the corresponding caps and sent out
the cap update request with old 'seq', the mds will miss checking
the seqs and calculating the caps.
We should always send an ack for revoke requests.
Fixes: https://tracker.ceph.com/issues/61782
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows