mgr/dashboard: empty list of fs clients with no mds #52076
Merged
nizamial09 merged 1 commit intoceph:mainfrom Jun 16, 2023
Merged
mgr/dashboard: empty list of fs clients with no mds #52076nizamial09 merged 1 commit intoceph:mainfrom
nizamial09 merged 1 commit intoceph:mainfrom
Conversation
nizamial09
reviewed
Jun 15, 2023
Member
nizamial09
left a comment
There was a problem hiding this comment.
@pereman2 could you create tracker and attach it in the commit?
Member
|
jenkins test dashboard |
Member
|
jenkins test dashboard cephadm |
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com> Fixes: https://tracker.ceph.com/issues/61708
d7528c4 to
f24f5f3
Compare
Member
|
jenkins test dashboard |
nizamial09
approved these changes
Jun 16, 2023
Contributor
|
this will affect the negative tests where we expect non-success response codes. In one such case #52258 where the FS is failed and the |
This was referenced Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no mds are configured on the filesystem retrieving clients will raise an exception, hence, let's just return an empty list in this case.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows