mds: fix the description for inotable testing only options by lxbsz · Pull Request #52024 · ceph/ceph

lxbsz · 2023-06-13T10:34:13Z

The description text are mixed for mds_kill_skip_replaying_inotable and mds_inject_skip_replaying_inotable.

Fixes: https://tracker.ceph.com/issues/61660

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

mchangir

Descriptions look better. But I'm still not comfortable with the option name mds_kill_skip_replaying_inotable.

lxbsz · 2023-06-13T10:56:59Z

Descriptions look better. But I'm still not comfortable with the option name mds_kill_skip_replaying_inotable.

Any better name ? I can fix it together.

dparmar18 · 2023-06-13T11:43:27Z

Descriptions look better. But I'm still not comfortable with the option name mds_kill_skip_replaying_inotable.

Any better name ? I can fix it together.

maybe mds_kill_after_journal_logs_flush ?

lxbsz · 2023-06-13T12:11:34Z

Descriptions look better. But I'm still not comfortable with the option name mds_kill_skip_replaying_inotable.

Any better name ? I can fix it together.

maybe mds_kill_after_journal_logs_flush ?

yeah, this looks better, if no objection I will rename it later. Thanks @dparmar18

gregsfortytwo

If you're going to rename the config option (👍) then you need to update the tests and the docs (as tagged! as well.

joscollin · 2023-06-13T13:44:04Z

https://tracker.ceph.com/issues/61660
I think the renaming is out of scope.

lxbsz · 2023-06-13T23:22:23Z

If you're going to rename the config option (+1) then you need to update the tests and the docs (as tagged! as well.

Done. Thanks.

lxbsz · 2023-06-13T23:23:37Z

https://tracker.ceph.com/issues/61660 I think the renaming is out of scope.

Updated the tracker. Thanks.

names changed after this review

rishabh-d-dave

LGTM. It would be nicer if you add a note about why are renaming this option in commit message as well as on tracker ticket. If this affects the users too, maybe add a release note as well?

lxbsz · 2023-06-16T23:32:59Z

LGTM. It would be nicer if you add a note about why are renaming this option in commit message as well as on tracker ticket. If this affects the users too, maybe add a release note as well?

Sure, will do. Thanks.

PendingReleaseNotes

kotreshhr · 2023-06-20T06:33:26Z

src/common/options/mds.yaml.in

  - mds
-  fmt_desc: Ceph will skip replaying the inotable when replaying the journal, and
-    the premary MDS will crash, while the replacing MDS won't.
+  fmt_desc: The primary MDS will crash just after the mknode/openc journal logs


s/mknode/mknod ?

Done. thanks.

dparmar18 · 2023-06-30T06:59:44Z

@lxbsz the last push was just a rebase right?

dparmar18 · 2023-06-30T07:00:13Z

jenkins test api

lxbsz · 2023-09-08T02:02:13Z

Rebased it.

github-actions · 2023-09-26T14:36:50Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

The description text are mixed for mds_kill_skip_replaying_inotable and mds_inject_skip_replaying_inotable. At the same time rename "mds_kill_skip_replaying_inotable", which is a bit confusing to "mds_kill_after_journal_logs_flushed". Fixes: https://tracker.ceph.com/issues/61660 Signed-off-by: Xiubo Li <xiubli@redhat.com>

lxbsz · 2023-09-27T00:57:22Z

Rebased it.

@rishabh-d-dave @vshankar Could you help add this to your next qa tests ? Thanks!

rishabh-d-dave · 2023-10-13T19:27:14Z

Rebased it.

@rishabh-d-dave @vshankar Could you help add this to your next qa tests ? Thanks!

I'll pick this up in next batch.

github-actions · 2023-12-12T20:01:41Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

lxbsz · 2023-12-26T01:53:35Z

Rebased it.
@rishabh-d-dave @vshankar Could you help add this to your next qa tests ? Thanks!

I'll pick this up in next batch.

@rishabh-d-dave Ping ?

vshankar · 2024-01-19T07:43:14Z

Rebased it.
@rishabh-d-dave @vshankar Could you help add this to your next qa tests ? Thanks!

I'll pick this up in next batch.

@rishabh-d-dave Ping ?

@rishabh-d-dave pinging again?

github-actions · 2024-03-19T08:01:33Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

rishabh-d-dave · 2024-03-22T17:21:50Z

jenkins test api

lxbsz · 2024-03-25T03:40:21Z

jenkins test make check arm64

rishabh-d-dave

QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/Main#26-APR-2024

rishabh-d-dave · 2024-04-26T10:52:15Z

Talked with Xiubo about this. Since it has approvals and QA is successful, I can proceed to merge.

Requested changes have been incorporated.

lxbsz requested review from a team and mchangir June 13, 2023 10:34

github-actions bot added the common label Jun 13, 2023

mchangir reviewed Jun 13, 2023

View reviewed changes

joscollin previously approved these changes Jun 13, 2023

View reviewed changes

lxbsz force-pushed the wip-61660 branch from eb02c43 to 323b91b Compare June 13, 2023 12:17

github-actions bot added the cephfs Ceph File System label Jun 13, 2023

lxbsz force-pushed the wip-61660 branch from 323b91b to 4f7a61a Compare June 13, 2023 12:18

gregsfortytwo previously requested changes Jun 13, 2023

View reviewed changes

lxbsz force-pushed the wip-61660 branch from 4f7a61a to a2d8b6f Compare June 13, 2023 23:22

lxbsz requested a review from a team as a code owner June 13, 2023 23:22

github-actions bot added documentation tests labels Jun 13, 2023

rishabh-d-dave approved these changes Jun 16, 2023

View reviewed changes

lxbsz force-pushed the wip-61660 branch 2 times, most recently from c54eb61 to 5850531 Compare June 16, 2023 23:42

dparmar18 reviewed Jun 19, 2023

View reviewed changes

PendingReleaseNotes Outdated Show resolved Hide resolved

kotreshhr reviewed Jun 20, 2023

View reviewed changes

lxbsz force-pushed the wip-61660 branch from 5850531 to 3a3eb5f Compare June 29, 2023 04:44

dparmar18 approved these changes Jun 30, 2023

View reviewed changes

lxbsz force-pushed the wip-61660 branch from 794fcb2 to 42f6014 Compare September 8, 2023 02:01

github-actions bot removed the needs-rebase label Sep 8, 2023

github-actions bot added the needs-rebase label Sep 26, 2023

lxbsz force-pushed the wip-61660 branch from 42f6014 to 7df5714 Compare September 27, 2023 00:56

github-actions bot removed the needs-rebase label Sep 27, 2023

github-actions bot added the stale label Dec 12, 2023

lxbsz removed the stale label Dec 26, 2023

github-actions bot added the stale label Mar 19, 2024

rishabh-d-dave added needs-qa and removed stale labels Mar 22, 2024

rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Apr 12, 2024

rishabh-d-dave approved these changes Apr 26, 2024

View reviewed changes

rishabh-d-dave removed the needs-qa label Apr 26, 2024

rishabh-d-dave merged commit 4a05c14 into ceph:main Apr 26, 2024

This was referenced Apr 28, 2024

quincy: mds: fix the description for inotable testing only options #57114

Merged

reef: mds: fix the description for inotable testing only options #57115

Merged

squid: mds: fix the description for inotable testing only options #57116

Merged

Conversation

lxbsz commented Jun 13, 2023 • edited by joscollin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

mchangir left a comment

Choose a reason for hiding this comment

Uh oh!

lxbsz commented Jun 13, 2023

Uh oh!

dparmar18 commented Jun 13, 2023

Uh oh!

lxbsz commented Jun 13, 2023

Uh oh!

gregsfortytwo left a comment

Choose a reason for hiding this comment

Uh oh!

joscollin commented Jun 13, 2023

Uh oh!

lxbsz commented Jun 13, 2023

Uh oh!

lxbsz commented Jun 13, 2023

Uh oh!

rishabh-d-dave left a comment

Choose a reason for hiding this comment

Uh oh!

lxbsz commented Jun 16, 2023

Uh oh!

Uh oh!

kotreshhr Jun 20, 2023

Choose a reason for hiding this comment

Uh oh!

lxbsz Jun 29, 2023

Choose a reason for hiding this comment

Uh oh!

dparmar18 commented Jun 30, 2023

Uh oh!

dparmar18 commented Jun 30, 2023

Uh oh!

lxbsz commented Sep 8, 2023

Uh oh!

github-actions bot commented Sep 26, 2023

Uh oh!

lxbsz commented Sep 27, 2023

Uh oh!

rishabh-d-dave commented Oct 13, 2023

Uh oh!

github-actions bot commented Dec 12, 2023

Uh oh!

lxbsz commented Dec 26, 2023

Uh oh!

vshankar commented Jan 19, 2024

Uh oh!

github-actions bot commented Mar 19, 2024

Uh oh!

rishabh-d-dave commented Mar 22, 2024

Uh oh!

lxbsz commented Mar 25, 2024

Uh oh!

rishabh-d-dave left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented Apr 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

lxbsz commented Jun 13, 2023 •

edited by joscollin

Loading