qa: wait for file to have correct size#51995
Merged
Conversation
Otherwise suspending the netns of the other mount will prevent it from completing a flush on the file handle or even telling the MDS that the file size has changed! Fixes: https://tracker.ceph.com/issues/61409 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Member
Author
|
main: https://pulpito.ceph.com/pdonnell-2023-06-10_18:19:40-fs:functional-main-distro-default-smithi/ main + this PR: https://pulpito.ceph.com/pdonnell-2023-06-10_18:20:34-fs:functional-main-distro-default-smithi/ The failure is: https://tracker.ceph.com/issues/57682 The other tests do not fail without this PR because it's a racy test. It's only easily reproduced in combination with |
14 tasks
Member
Author
|
jenkins test api |
dparmar18
reviewed
Jun 12, 2023
|
|
||
| self.mount_b.check_filelock(do_flock=flockable) | ||
|
|
||
| # Tear down the background process |
Contributor
There was a problem hiding this comment.
removal of these comments is intentional right? Looks too trivial
Member
Author
There was a problem hiding this comment.
Yes. They're ultra-redundant.
This was referenced Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise suspending the netns of the other mount will prevent it from completing a flush on the file handle or even telling the MDS that the file size has changed!
Fixes: https://tracker.ceph.com/issues/61409
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows