Skip to content

Crimson/osd: Disable concurrent MOSDMap handling#51961

Merged
Matan-B merged 9 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-single-mosdmap-handling
Jun 22, 2023
Merged

Crimson/osd: Disable concurrent MOSDMap handling#51961
Matan-B merged 9 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-single-mosdmap-handling

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Jun 7, 2023

Fixes: https://tracker.ceph.com/issues/59165

Note: This PR is originated from #51425 and #51860 attempts to avoid introducing new seastar::shared_mutex member. However, in order to avoid unnecessary complexity in the code for non-significant impact on performance the current change was favoured.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Matan-B Matan-B requested review from athanatos and rzarzynski June 7, 2023 15:10
@Matan-B Matan-B requested a review from a team as a code owner June 7, 2023 15:10
@Matan-B Matan-B mentioned this pull request Jun 7, 2023
Closed
14 tasks
rzarzynski
rzarzynski approved these changes Jun 7, 2023
View reviewed changes
@Matan-B Matan-B force-pushed the wip-matanb-crimson-single-mosdmap-handling branch 2 times, most recently from 4b6f53c to 55c03cf Compare June 7, 2023 17:58
athanatos
athanatos requested changes Jun 7, 2023
View reviewed changes
@Matan-B Matan-B force-pushed the wip-matanb-crimson-single-mosdmap-handling branch from 55c03cf to ed29d70 Compare June 8, 2023 07:51
@Matan-B Matan-B requested a review from athanatos June 8, 2023 07:54
@Matan-B Matan-B mentioned this pull request Jun 12, 2023
Merged
14 tasks
@Matan-B Matan-B added the DNM label Jun 12, 2023
Matan-B
Matan-B commented Jun 12, 2023
View reviewed changes
Matan-B added 2 commits June 13, 2023 07:33
@Matan-B
crimson/osd/osd: serialize MOSDMap message handling
63fa59c 
See included comment for rationale.

Fixes: https://tracker.ceph.com/issues/59165
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/osd: handle_osd_map() remove unused ConnectionRef conn
3bae740 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-single-mosdmap-handling branch 2 times, most recently from 2c20bf3 to cf9d96f Compare June 15, 2023 12:36
@Matan-B Matan-B force-pushed the wip-matanb-crimson-single-mosdmap-handling branch from cf9d96f to aa35013 Compare June 19, 2023 13:59
@Matan-B
Copy link
Contributor Author

Matan-B commented Jun 19, 2023 •
edited
Loading

Tests look good.
https://pulpito.ceph.com/matan-2023-06-19_11:10:19-crimson-rados-wip-matanb-crimson-single-mosdmap-handling-v3-distro-crimson-smithi/
@athanatos, requested another review since the last 2 commits are new. Thank you.

@Matan-B Matan-B requested a review from athanatos June 19, 2023 14:11
@Matan-B Matan-B force-pushed the wip-matanb-crimson-single-mosdmap-handling branch from 4dc18f9 to fe3626a Compare June 20, 2023 09:40
Matan-B added 5 commits June 20, 2023 17:14
@Matan-B
crimson/osd/pg: Fix assert of osd_debug_verify_cached_snaps
569fdda 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd: Add logs around handling of osdmaps
6dfb8f2 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/osd_meta: Abort instead of throwing runtime_error
558758f 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/shard_services: Refactor OSDSingletonState::load_map
ecac14a 
Added logs
If case reconstructed - epoch is unsigned.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/shard_services: get_or_create_pg() remove unused variable
a8800c7 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-single-mosdmap-handling branch 2 times, most recently from 1e13378 to 3c2aa28 Compare June 20, 2023 17:56
athanatos
athanatos requested changes Jun 20, 2023
View reviewed changes
Matan-B added 2 commits June 20, 2023 18:10
@Matan-B
crimson/osd/osdmap_gate: got_map() assert increase of current epoch
06bf661 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/osd_operations/pg_advance_map: 'from' epoch may vary betw…
ba519f5 
…een PGS explanation

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-single-mosdmap-handling branch from 3c2aa28 to ba519f5 Compare June 20, 2023 18:15
@Matan-B Matan-B requested a review from athanatos June 20, 2023 18:15
@Matan-B
Copy link
Contributor Author

Matan-B commented Jun 21, 2023

https://pulpito.ceph.com/matan-2023-06-21_12:00:29-crimson-rados-wip-matanb-crimson-single-mosdmap-handling-distro-crimson-smithi/

7309664, 7309667: https://tracker.ceph.com/issues/61651

@Matan-B Matan-B merged commit af70f82 into ceph:main Jun 22, 2023
@Matan-B Matan-B mentioned this pull request Oct 11, 2023
Merged
@Matan-B Matan-B mentioned this pull request Feb 8, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athanatos athanatos athanatos approved these changes

@rzarzynski rzarzynski rzarzynski approved these changes

Assignees

No one assigned

Labels

crimson wip-matan-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Matan-B @athanatos @rzarzynski