Skip to content

qa/suites/rados: remove rook coverage from the rados suite#51927

Merged
ljflores merged 1 commit intoceph:mainfrom
ljflores:wip-rook-tests
Jun 6, 2023
Merged

qa/suites/rados: remove rook coverage from the rados suite#51927
ljflores merged 1 commit intoceph:mainfrom
ljflores:wip-rook-tests

Conversation

@ljflores
Copy link
Member

@ljflores ljflores commented Jun 5, 2023

The rook team relies on a daily CI system to validate rook changes. It doesn't seem that the teuthology tests are maintained, so it makes sense to remove them from the rados suite.

By removing this symlink, rook test coverage will remain in the orch suite, and coverage will only be removed from the rados suite.

Workaround for: https://tracker.ceph.com/issues/58585
Signed-off-by: Laura Flores lflores@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

The rook team relies on a daily CI system to validate
rook changes. It doesn't seem that the teuthology tests
are maintained, so it makes sense to remove them from the
rados suite.

By removing this symlink, rook test coverage will remain
in the orch suite, and coverage will only be removed from the
rados suite.

Workaround for: https://tracker.ceph.com/issues/58585
Signed-off-by: Laura Flores <lflores@redhat.com>
@ljflores ljflores requested a review from a team as a code owner June 5, 2023 20:27
@github-actions github-actions bot added the core label Jun 5, 2023
@ljflores ljflores added the rook label Jun 5, 2023
@ljflores ljflores requested review from neha-ojha and travisn June 5, 2023 20:27
@ljflores
Copy link
Member Author

ljflores commented Jun 5, 2023

Hey @travisn, see what you think of this PR. We've had rook tests failing for quite awhile in the rados suite, but I think your team relies on a different set of tests for rook validation.

Are these tests maintained? If not, we should consider removing them.

@ljflores ljflores requested a review from rzarzynski June 5, 2023 20:41
@travisn
Copy link
Member

travisn commented Jun 5, 2023

Hey @travisn, see what you think of this PR. We've had rook tests failing for quite awhile in the rados suite, but I think your team relies on a different set of tests for rook validation.

Are these tests maintained? If not, we should consider removing them.

Correct, Rook relies on github actions in its own repo, such as the daily actions that can be seen here. I don't even recall who created the rook tests for teuthology, but if they are not being maintained, sounds good to remove them.

Copy link
Contributor

@rzarzynski rzarzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove then.

@ljflores
Copy link
Member Author

ljflores commented Jun 6, 2023

The only way to test this is to schedule a teuthology suite and check that any rook jobs have been added. I did this with rados and orch dry runs.

In rados, no more rook tests appear: https://paste.centos.org/view/5fb90a24

In orch, the rook tests are still there: https://paste.centos.org/view/8269c4c6

These can be removed from the orch suite as well, but I will leave it to cephadm folks to decide on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants