Conversation
|
jenkins test api |
kamoltat
left a comment
There was a problem hiding this comment.
Logic make sense, but should we give a specific time out for the while loop, I know it's probably not gonna be divergent -1 forever but I think it will be cleaner if we have a set time lets say 300 seconds for the while checkout for divergent less than or equal -1.
@NitzanMordhai Let me know what you think.
When creating new pool, the current code pick the divergent osd by the first pg out of pg dump pgs, that can be in "unknown" status which means the up_primary = -1 and that will fail the test. We need to wait unitl the first pg is active+clean Fixes: https://tracker.ceph.com/issues/56034 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
48b5310 to
13c640b
Compare
@kamoltat yes, sounds like a better way to control the while, added. |
|
jenkins retest this please |
|
jenkins test make check |
|
jenkins test make check |
When creating new pool, the current code pick the divergent osd by the first pg out of pg dump pgs, that can be in "unknown" status which means the up_primary = -1 and that will fail the test. We need to wait unitl the first pg is active+clean
Fixes: https://tracker.ceph.com/issues/56034
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows