rgw/notification/kafka: simplify kafka connection memory management#51662
Merged
rgw/notification/kafka: simplify kafka connection memory management#51662
Conversation
use a bare pointer and a unique_ptr instead of a shared pointer (boost::intrusive_ptr). and use the broker name as the handle exposed outside of the kafka module. Fixes: https://tracker.ceph.com/issues/61328 Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Contributor
Author
|
jenkins test make check |
cbodley
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use a bare pointer and a unique_ptr instead of a shared pointer (boost::intrusive_ptr). and use the broker name as the handle exposed outside of the kafka module.
Fixes: https://tracker.ceph.com/issues/61328
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows