Skip to content

qa/ceph_manager: preserve newline char at EOF in keyring#50876

Merged
yuriw merged 1 commit intoceph:mainfrom
rishabh-d-dave:qa-ceph-man-get-keyring
May 25, 2023
Merged

qa/ceph_manager: preserve newline char at EOF in keyring#50876
yuriw merged 1 commit intoceph:mainfrom
rishabh-d-dave:qa-ceph-man-get-keyring

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Apr 5, 2023 •
edited
Loading

Lack of newline character at the end of keyring file makes CephFS mount
command end with error.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@rishabh-d-dave rishabh-d-dave requested a review from a team April 5, 2023 15:48
@rishabh-d-dave rishabh-d-dave force-pushed the qa-ceph-man-get-keyring branch from 21b3606 to bdc6587 Compare April 6, 2023 11:10
@rishabh-d-dave rishabh-d-dave mentioned this pull request Apr 7, 2023
Merged
4 tasks
@rishabh-d-dave
qa/ceph_manager: preserve newline char at EOF in keyring
1944977 
Lack of newline character at the end of keyring file makes CephFS mount
command end with error.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave rishabh-d-dave force-pushed the qa-ceph-man-get-keyring branch from bdc6587 to 1944977 Compare April 11, 2023 10:39
@rishabh-d-dave rishabh-d-dave changed the title qa/ceph_manager: fix bug in get_keyring() qa/ceph_manager: preserve newline char at EOF in keyring Apr 11, 2023
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 11, 2023

Re-wrote commit title, no change in code.

@batrick
Copy link
Member

batrick commented Apr 11, 2023

Lack of newline character at the end of keyring file makes CephFS mount
command end with error.

This fix is good but it seems to me the mount command should not depend on superfluous whitespace in the keyring. Let's fix that?

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 11, 2023

Lack of newline character at the end of keyring file makes CephFS mount
command end with error.

This fix is good but it seems to me the mount command should not depend on superfluous whitespace in the keyring. Let's fix that?

Yes. I'm on it.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 11, 2023

@ljflores Please include this one too in next QA run.

@ljflores
Copy link
Member

ljflores commented May 8, 2023

Rados suite results: http://pulpito.front.sepia.ceph.com/?branch=wip-yuri7-testing-2023-04-19-1343

Failures, unrelated:
1. https://tracker.ceph.com/issues/57755
2. https://tracker.ceph.com/issues/58946
3. https://tracker.ceph.com/issues/49888
4. https://tracker.ceph.com/issues/59380
5. https://tracker.ceph.com/issues/57754
6. https://tracker.ceph.com/issues/55347
7. https://tracker.ceph.com/issues/49287

Details:
1. task/test_orch_cli: test_cephfs_mirror times out - Ceph - Orchestrator
2. cephadm: KeyError: 'osdspec_affinity' - Ceph - Mgr - Dashboard
3. rados/singleton: radosbench.py: teuthology.exceptions.MaxWhileTries: reached maximum tries (3650) after waiting for 21900 seconds - Ceph - RADOS
4. rados/singleton-nomsgr: test failing from "Health check failed: 1 full osd(s) (OSD_FULL)" and "Health check failed: 1 filesystem is offline (MDS_ALL_DOWN)" - Ceph - RGW
5. test_envlibrados_for_rocksdb.sh: update-alternatives: error: alternative path /usr/bin/gcc-11 doesn't exist - Ceph - RADOS
6. SELinux Denials during cephadm/workunits/test_cephadm - Ceph - Orchestrator
7. podman: setting cgroup config for procHooks process caused: Unit libpod-$hash.scope not found - Ceph - Orchestrator

@kotreshhr
Copy link
Contributor

kotreshhr commented May 24, 2023

jenkins test windows

@kotreshhr
Copy link
Contributor

kotreshhr commented May 24, 2023

jenkins test make check arm64

@yuriw yuriw merged commit 40b9a8b into ceph:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dparmar18 dparmar18 dparmar18 approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System needs-qa tests wip-yuri7-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rishabh-d-dave @batrick @ljflores @kotreshhr @dparmar18 @yuriw