qa/cephfs: upgrade gen_mds_cap_str() in caps_helper #50664
Merged
rishabh-d-dave merged 2 commits intoceph:mainfrom Apr 5, 2023
Merged
qa/cephfs: upgrade gen_mds_cap_str() in caps_helper #50664rishabh-d-dave merged 2 commits intoceph:mainfrom
rishabh-d-dave merged 2 commits intoceph:mainfrom
Conversation
vshankar
requested changes
Mar 28, 2023
Contributor
vshankar
left a comment
There was a problem hiding this comment.
This can be passed in as a keyword arg, isn't it? That would make things easier to extend when the need arises.
Modify get_mds_cap_str() to accept a tuple with a single member. In this case, the only member is assumed to be a permission, FS name is assigned None type and cephfs_mntpt is assigned '/'. Signed-off-by: Rishabh Dave <ridave@redhat.com>
9618755 to
0934845
Compare
Contributor
Author
Yes, that will be improvement. |
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Contributor
Author
4 tasks
Contributor
Author
|
jenkins test api |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify get_mds_cap_str() to accept a tuple with a single member. In this
case, the only member is assumed to be a permission, FS name is assigned
None type and cephfs_mntpt is assigned '/'.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows