Skip to content

qa/suites/crimson-rados/rbd: Add new rbd image format api tests#50457

Merged
Matan-B merged 3 commits intoceph:mainfrom
Matan-B:wip-matanb-c-new-rbd-api
May 2, 2023
Merged

qa/suites/crimson-rados/rbd: Add new rbd image format api tests#50457
Matan-B merged 3 commits intoceph:mainfrom
Matan-B:wip-matanb-c-new-rbd-api

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Mar 9, 2023 •
edited
Loading

Use the second rbd image format while testing rbd api in the Crimson suite.
Currently the suite included only old format testing (rbd_api_tests_old_format).

https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-only-new-rbd/
https://pulpito.ceph.com/matan-2023-03-09_15:12:05-crimson-rados-wip-matanb-crimson-only-new-rbd-distro-crimson-smithi/

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Matan-B Matan-B added the crimson label Mar 9, 2023
@Matan-B Matan-B requested a review from a team March 9, 2023 13:04
athanatos
athanatos approved these changes Mar 10, 2023
View reviewed changes
@Matan-B Matan-B force-pushed the wip-matanb-c-new-rbd-api branch from fee4f94 to f0f2214 Compare March 21, 2023 09:47
@Matan-B Matan-B marked this pull request as ready for review March 21, 2023 09:49
@Matan-B Matan-B requested a review from a team as a code owner March 21, 2023 09:49
@Matan-B Matan-B requested a review from idryomov March 21, 2023 09:51
@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 21, 2023

jenkins test make check

idryomov
idryomov reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to tweak the "test/librbd/test_librbd: Skip ListChildrenTiered" commit title to also say "(Crimson)".

@Matan-B Matan-B force-pushed the wip-matanb-c-new-rbd-api branch from f0f2214 to 12fa8fa Compare March 22, 2023 10:50
@Matan-B Matan-B requested a review from idryomov March 22, 2023 10:52
idryomov
idryomov reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm wondering if this was run through teuthology after 1 -> 61 change? That should have enabled a bunch of new tests and I'm a little surprised that it's still the case that only one test needed to be silenced due to https://tracker.ceph.com/issues/58263.

@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 22, 2023 •
edited
Loading

LGTM but I'm wondering if this was run through teuthology after 1 -> 61 change? That should have enabled a bunch of new tests and I'm a little surprised that it's still the case that only one test needed to be silenced due to https://tracker.ceph.com/issues/58263.

There are few other tests which are failing w/ Crimson and the new format enabled. Instead of silencing each one and opening a separate tracker for them, I think it will be better to include the new format test in the suite first and then we could resolve each one of them sperately.

I didn't observe any more tests related to https://tracker.ceph.com/issues/58263 in test_librbd. However, it's possible there are others.

@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 22, 2023

https://pulpito.ceph.com/matan-2023-03-22_13:10:56-crimson-rados-wip-matanb-crimson-only-testing-22.3-distro-crimson-smithi/

Branches included:

Merge branch 'wip-matanb-c-snaps-tests' into wip-matanb-crimson-only-testing-22.3                                                
Merge branch 'wip-matanb-crimson-only-order-snap' into wip-matanb-crimson-only-testing-22.3
Merge branch 'wip-matanb-c-logging-levels' into wip-matanb-crimson-only-testing-22.3 
Merge branch 'wip-matanb-c-new-rbd-api' into wip-matanb-crimson-only-testing-22.3

@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 22, 2023

https://pulpito.ceph.com/matan-2023-03-22_13:10:56-crimson-rados-wip-matanb-crimson-only-testing-22.3-distro-crimson-smithi/7216275/
@athanatos, Should I merge this additional test although it fails atm? It will help identifying unsupported cases until they are resovled.

[  FAILED  ] TestLibRBD.BreakLock (5449 ms)
[  FAILED  ] TestLibRBD.QuiesceWatchError (5262 ms)
[ RUN      ] TestLibRBD.ConcurentOperations - hits an assertion

@Matan-B Matan-B requested a review from athanatos March 22, 2023 14:33
@idryomov
Copy link
Contributor

idryomov commented Mar 22, 2023 •
edited
Loading 

[  FAILED  ] TestLibRBD.BreakLock (5449 ms)
[  FAILED  ] TestLibRBD.QuiesceWatchError (5262 ms)
[ RUN      ] TestLibRBD.ConcurentOperations - hits an assertion

This is only what failed before ceph_assert terminated the whole thing. I would suggest getting through a run with TestLibRBD.ConcurentOperations disabled to get the complete list of current failures.

@Matan-B Matan-B force-pushed the wip-matanb-c-new-rbd-api branch from 12fa8fa to 3c4542a Compare March 23, 2023 09:38
idryomov
idryomov approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of five "skip this test" one-line commits, three have no description and the description in the forth just duplicates a code comment. I would suggest squashing all of them into a single commit, as it's pretty self explanatory.

@Matan-B Matan-B force-pushed the wip-matanb-c-new-rbd-api branch from 3c4542a to d3f9192 Compare March 26, 2023 14:17
@Matan-B Matan-B force-pushed the wip-matanb-c-new-rbd-api branch from d3f9192 to 55f979f Compare April 25, 2023 10:16
idryomov
idryomov reviewed Apr 25, 2023
View reviewed changes
@Matan-B Matan-B force-pushed the wip-matanb-c-new-rbd-api branch 2 times, most recently from b704604 to fd01cf6 Compare April 27, 2023 09:18
athanatos
athanatos approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@athanatos athanatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 30, 2023

jenkins test make check

This was referenced May 1, 2023
Merged
Merged
Merged
Merged
Matan-B added 3 commits May 1, 2023 09:09
@Matan-B
test/librbd: Skip unsupported Crimson tests
89d50e9 
This commit is part of an initial attempt to establish a Crimson testing baseline.

test_librbd notes:

* Skip ListChildrenTiered (Crimson):
  Cache tiering is not supported.

test_internal notes:

* Skip SnapshotCopyup (Crimson):
  Clone overlap calculation is WIP: https://tracker.ceph.com/issues/58263

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
qa/suites/crimson-rados/rbd: Add new rbd image format api tests
27e309e 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
test/cls_rbd/test_cls_rbd: Skip mirror_image_status (Crimson)
32fecf1 
This commit is part of an initial attempt to establish a Crimson testing baseline.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-c-new-rbd-api branch from fd01cf6 to 32fecf1 Compare May 1, 2023 09:10
@Matan-B
Copy link
Contributor Author

Matan-B commented May 2, 2023

jenkins test make check

@Matan-B Matan-B merged commit 010e298 into ceph:main May 2, 2023
@Matan-B Matan-B mentioned this pull request May 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athanatos athanatos athanatos approved these changes

@idryomov idryomov idryomov approved these changes

Assignees

No one assigned

Labels

crimson rbd tests wip-matan-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Matan-B @idryomov @athanatos