osd: don't send stale hb msgr's addresses in MOSDBoot#50422
osd: don't send stale hb msgr's addresses in MOSDBoot#50422rzarzynski merged 1 commit intoceph:mainfrom
Conversation
See comments in the ticket for the RCA.
NOTE: we can't just hold a reference to what `get_myaddrs()`
returns as the `safe_item_history` is involved:
```cpp
template<class T>
class safe_item_history {
//...
T *current = nullptr;
// ...
const T& operator=(const T& other) {
std::lock_guard l(lock);
history.push_back(other);
current = &history.back();
return *current;
}
```
Fixes: https://tracker.ceph.com/issues/58915
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
|
jenkins test make check |
|
@rzarzynski I had to open this new tracker, which reproduced twice: https://tracker.ceph.com/issues/59333 Can you check that this is not related to your PR? If it's not, feel free to merge. Rados suite review: Failures, unrelated: Details: |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
|
@rzarzynski ping |
|
Thanks for resurrecting this, @ljflores! Let's get it into |
See comments in the ticket for the RCA.
NOTE: we can't just hold a reference to what
get_myaddrs()returns as thesafe_item_historyis involved:Fixes: https://tracker.ceph.com/issues/58915
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows