rgw: use unique_ptr for flat_map emplace in BucketTrimWatche#50346
Merged
rgw: use unique_ptr for flat_map emplace in BucketTrimWatche#50346
Conversation
cbodley
reviewed
Mar 2, 2023
Contributor
|
@vedanshbhartia oh, I see--yuval marked this as a coverity warning. cool! |
When emplacing objects into the trim notify handler of BucketTrimWatcher, use a unique_ptr for the handler so that it is destroyed if the emplace fails. Though the destructor is already called, this behaviour cannot be relied upon. std::map does not exhibit the same behaviour, and would have leaked memory had it been used instead. Fixes: https://tracker.ceph.com/issues/57938 Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>
cbodley
approved these changes
Mar 2, 2023
Contributor
cbodley
left a comment
There was a problem hiding this comment.
looks great. thanks for the detailed commit message
Contributor
|
jenkins test make check |
Contributor
This was referenced Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows