Skip to content

mds: memset the head by default to fix the readable.sh test failure#50268

Merged
vshankar merged 1 commit intoceph:mainfrom
lxbsz:readable_fix
Feb 28, 2023
Merged

mds: memset the head by default to fix the readable.sh test failure#50268
vshankar merged 1 commit intoceph:mainfrom
lxbsz:readable_fix

Conversation

@lxbsz
Copy link
Member

@lxbsz lxbsz commented Feb 27, 2023 •
edited by dparmar18
Loading

Fixes: https://tracker.ceph.com/issues/58853

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@lxbsz lxbsz requested a review from a team February 27, 2023 04:59
@lxbsz lxbsz changed the title mds: meset the head by default to fix the readable.sh test failure mds: memset the head by default to fix the readable.sh test failure Feb 27, 2023
This was referenced Feb 27, 2023
Closed
Merged
dparmar18
dparmar18 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@dparmar18 dparmar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vshankar
Copy link
Contributor

vshankar commented Feb 27, 2023

@lxbsz Could you add Introduced-by: <commit-id> in the commit? Also, this change needs to be alongside backports.

@lxbsz
mds: memset the head by default to fix the readable.sh test failure
9d11376 
Introduced-by: cbd7e30(ceph_fs.h: add 32 bits extended num_retry and num_fwd support)
Fixes: https://tracker.ceph.com/issues/58853
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
Copy link
Member Author

lxbsz commented Feb 27, 2023 •
edited
Loading

@lxbsz Could you add Introduced-by: <commit-id> in the commit? Also, this change needs to be alongside backports.

Done.

It was introduced by #45669, before why that PR didn't fail should be the ext_num_fwd and ext_num_retry in head were initialized as 0 randomly in the readable.sh test case.

@vshankar vshankar added the cephfs Ceph File System label Feb 27, 2023
@lxbsz
Copy link
Member Author

lxbsz commented Feb 27, 2023

jenkins test make check

@vshankar vshankar mentioned this pull request Feb 28, 2023
Merged
14 tasks
@vshankar vshankar merged commit 222c3e0 into ceph:main Feb 28, 2023
@vshankar vshankar removed the needs-qa label Feb 28, 2023
This was referenced Mar 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick batrick approved these changes

@kotreshhr kotreshhr kotreshhr approved these changes

@dparmar18 dparmar18 dparmar18 approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lxbsz @vshankar @batrick @kotreshhr @dparmar18