test/osd-scrub-dump.sh: fix scrub chunk size#50236
Merged
Conversation
Member
|
jenkins test api |
Member
|
jenkins test make check |
athanatos
approved these changes
Feb 23, 2023
Contributor
athanatos
left a comment
There was a problem hiding this comment.
LGTM other than the sleep change -- not sure what the intention is there.
| fi | ||
| total=$(expr $total + $pass) | ||
| sleep $(expr $SCRUB_SLEEP \* 2) | ||
| sleep $(expr $SCRUB_SLEEP \* 2 - 2) |
Contributor
Author
There was a problem hiding this comment.
I've accidentally removed the relevant part in the commit message. The sleeps, esp. the first one, were too long
(as evident from the gist linked in the PR message).
I'll restore the explanation.
Contributor
Author
There was a problem hiding this comment.
... and simplify the code
c189f9e to
cc7fede
Compare
The test performs shallow scrubs, intentionally using small chunk sizes to allow dump commands time to check specific details. Following commit ffda641 (PR#44749), shallow scrubs chunks are controlled by a separate configuration parameter. This PR fixes the test to use the correct parameter. An additional minor change is an adjustment to the test loop sleep time: it is now reduced to guarantee that a dump followed by a counter increase will be performed in more-or-less the scrubs frequency. Fixes: https://tracker.ceph.com/issues/58797 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
cc7fede to
ce7e132
Compare
Contributor
Author
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test performs shallow scrubs, intentionally using small chunk sizes to allow dump commands time to check specific details. Following commit ffda641 (PR#44749), shallow scrubs chunks are controlled by a separate configuration parameter. This PR fixes the test to use the correct parameter.
An additional minor change is an adjustment to the test loop sleep time:
See https://gist.github.com/ronen-fr/e1aaf304ffff7a7c71073b09fde2197e for a sample pre-change run presenting
the timing of replica & local reservations vs the test samples. Note the initial delay in the test sampling.
Fixes: https://tracker.ceph.com/issues/58797