rgw/rados: remove sal handles from RGWRados::Object ops#50169
Merged
rgw/rados: remove sal handles from RGWRados::Object ops#50169
Conversation
use RGWObjState::attrset instead Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
these had no callers above zipper Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
Author
|
sorry for the massive commit. there wasn't really a way to break it up and still compile after each commit |
cbodley
commented
Feb 20, 2023
| protected: | ||
| RGWObjState state; | ||
| Bucket* bucket; | ||
| Attrs attrs; |
Contributor
Author
There was a problem hiding this comment.
@dang do you know of any specific need to keep attrs separate from state.attrset? get_attrs()/set_attrs()/has_attrs() are all based on the latter
Contributor
There was a problem hiding this comment.
No, attrs predates RGWObjState being there at all, so it can go.
dang
approved these changes
Feb 20, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a cleanup of the
RGWRadoslayer that restores many functions to their pre-pacific form, where buckets are passed asRGWBucketInfo&and objects are passed asconst rgw_obj&. this avoids a lots of cases where we had to allocate sal objects just to specify an object name. this also removed some sal APIs that had only been used internally by rgw_sal_sadosShow available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows