Skip to content

qa/distros: pass --allowerasing --nobest when installing container-tools#50146

Merged
adk3798 merged 1 commit intoceph:mainfrom
adk3798:container-selinux-conflict
Mar 7, 2023
Merged

qa/distros: pass --allowerasing --nobest when installing container-tools#50146
adk3798 merged 1 commit intoceph:mainfrom
adk3798:container-selinux-conflict

Conversation

@adk3798
Copy link
Contributor

@adk3798 adk3798 commented Feb 16, 2023

Fixes: https://tracker.ceph.com/issues/57771

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@adk3798
Copy link
Contributor Author

adk3798 commented Feb 27, 2023

https://pulpito.ceph.com/adking-2023-02-21_05:38:18-orch:cephadm-wip-adk-testing-2023-02-20-1650-distro-default-smithi/

failed/dead job reruns: https://pulpito.ceph.com/adking-2023-02-24_17:44:54-orch:cephadm-wip-adk-testing-2023-02-20-1650-distro-default-smithi/

After reruns, 3 failures and 1 dead job

  • dead job was failure pulling a podman package
Failed to download packages: podman-docker-3:4.3.1-2.module_el8.8.0+1254+78119b6e.noarch:
  Cannot download, all mirrors were already tried without success

Another instance of this test passed in original run so didn't bother with another rerun

  • 2 failures were staggered upgrade test issue tracked by https://tracker.ceph.com/issues/58535
  • last failure was in currently flaky test_nfs task test. Passed when I tried an interactive rerun for debugging

Overall, nothing to block merging. Will note initial version of basic monitoring stack test passed.

phlogistonjohn
phlogistonjohn approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Nitpick: while it is great to include the tracker link, it can also be nice to include a short line inthe commit message explaining why. For example: "Works around a package conflict on rhel/centos 8"

@rkachach
Copy link
Contributor

rkachach commented Feb 28, 2023 •
edited
Loading

It seems that the solution [1] to this issue is to exclude container-selinux-2:2.189.0. I think by "forcing" the instalation may endup with broken packges. WDYT? Is this something Infra people can fix?

[1] https://bugs.launchpad.net/tripleo/+bug/1990810
[2] https://review.opendev.org/c/openstack/tripleo-quickstart/+/859213

rkachach
rkachach approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@rkachach rkachach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: I'll recommend to keep the tracker open as in fact the changes on this PR fix the installation error but probably we should fix the original test and address the package conflict issue.

@adk3798
qa/distros: pass --allowerasing --nobest when installing container-tools
3011d95 
One of the tests in the orch suite is running distro install
commands from multiple distros, causing it to first install
container-tools 3.0 and then later install container-tools,
which fails, causing the test to fail. This is sort of a bandaid
fix to getthe test to work. It will cause whatever the last
version of the package to be installed to end up being installed
(and will do so without error) which is what we want in the tests.

Fixes: https://tracker.ceph.com/issues/57771

Signed-off-by: Adam King <adking@redhat.com>
@adk3798 adk3798 force-pushed the container-selinux-conflict branch from 7340f35 to 3011d95 Compare February 28, 2023 18:24
@adk3798
Copy link
Contributor Author

adk3798 commented Mar 7, 2023

https://pulpito.ceph.com/adking-2023-03-06_16:09:09-orch:cephadm-wip-adk-testing-2023-03-04-1231-distro-default-smithi/

Failed/dead jobs reruns: https://pulpito.ceph.com/adking-2023-03-06_21:04:02-orch:cephadm-wip-adk-testing-2023-03-04-1231-distro-default-smithi/

After reruns, 6 failed, 2 dead jobs:

  • 2 dead jobs were teuthology/infra issues (Could not get lock /var/lib/dpkg/lock-frontend, SSH connection to smithi038 was lost)
  • 1 job failed installing a kernel [Errno 2] No such file or directory: '/var/cache/dnf/CentOS-BaseOS-7c3d8b2bb640713c/packages/kernel-4.18.0-448.el8.x86_64.rpm' unrelated to our tests
  • 2 instances of https://tracker.ceph.com/issues/58535
  • 3 jobs failed due to changes made to ceph nfs cluster create command in another PR in the run

Overall, should only block merging for PRs related to nfs

@adk3798
Copy link
Contributor Author

adk3798 commented Mar 7, 2023

jenkins test make check

@adk3798 adk3798 merged commit 8cb8341 into ceph:main Mar 7, 2023
@adk3798 adk3798 mentioned this pull request Apr 25, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkachach rkachach rkachach approved these changes

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

Assignees

No one assigned

Labels

tests wip-adk-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adk3798 @rkachach @phlogistonjohn