Skip to content

qa/tasks/ceph_manager: wait till osd is up before injecting args#50126

Closed
NitzanMordhai wants to merge 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-thrasher-random-eio
Closed

qa/tasks/ceph_manager: wait till osd is up before injecting args#50126
NitzanMordhai wants to merge 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-thrasher-random-eio

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented Feb 15, 2023 •
edited
Loading

With random eio ceph_manager will inject args to live osds that may be restarted and not yet up. we need to wait until the osd is up before trying to inject args.

Fixes: https://tracker.ceph.com/issues/56097
Signed-off-by: Nitzan Mordechai nmordec@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@github-actions github-actions bot added the tests label Feb 15, 2023
@NitzanMordhai NitzanMordhai requested a review from a team February 15, 2023 11:43
@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Feb 16, 2023

jenkins retest this please

athanatos
athanatos approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@athanatos athanatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM

@NitzanMordhai
Copy link
Contributor Author

NitzanMordhai commented Feb 23, 2023

jenkins test api

@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-thrasher-random-eio branch from fa07328 to 67003b6 Compare April 25, 2023 04:30
@github-actions
Copy link

github-actions bot commented Aug 25, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Sep 24, 2023

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Sep 24, 2023
@athanatos
Copy link
Contributor

athanatos commented Sep 25, 2023

@NitzanMordhai Is there a reason this ended up stalling?

@NitzanMordhai NitzanMordhai reopened this Oct 22, 2023
@NitzanMordhai
qa/tasks/ceph_manager: wait till osd is up before injecting args
0701021 
With random eio ceph_manager will inject args to live osds that may
be restarted and not yet up. we need to wait until the osd is up
before trying to inject args.

Fixes: https://tracker.ceph.com/issues/56097
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
@NitzanMordhai NitzanMordhai force-pushed the wip-nitzan-thrasher-random-eio branch from 67003b6 to 0701021 Compare October 22, 2023 05:34
@github-actions github-actions bot removed the stale label Oct 22, 2023
@github-actions
Copy link

github-actions bot commented Dec 21, 2023

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 21, 2023
@github-actions
Copy link

github-actions bot commented Jan 20, 2024

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athanatos athanatos athanatos approved these changes

Assignees

No one assigned

Labels

needs-qa stale tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NitzanMordhai @athanatos