mds: add an asok command to dump export states by zhsgao · Pull Request #50105 · ceph/ceph

zhsgao · 2023-02-14T08:29:39Z

Task to export subtree may be blocked, use this command to find out what's going on.

Fixes: https://tracker.ceph.com/issues/58835
Signed-off-by: Zhansong Gao zhsgao@hotmail.com

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

vshankar · 2023-02-21T14:35:08Z

Nice idea. Will have a look at the changes.

dparmar18 · 2023-02-22T11:49:29Z

@zhsgao would be great to have a tracker for this

zhsgao · 2023-02-23T03:19:15Z

@zhsgao would be great to have a tracker for this

OK, I have added it.

src/mds/Migrator.cc

qa/tasks/cephfs/test_dump_export_states.py

src/mds/Migrator.h

dparmar18 · 2023-02-28T14:49:40Z

This needs to be documented somewhere, if not in docs then in PendingReleaseNotes?

vshankar · 2023-03-02T05:54:46Z

@zhsgao Fails api and make check failure:

API test:

Undefined Reference

Undefined reference in /usr/include/c++/11/bits/stl_map.h:1216 to `Migrator::EXPORT_DISCOVERING'
[Indication 1](https://jenkins.ceph.com/job/ceph-api/51697/consoleFull#-176439654385e1414f-af06-4588-8fed-ab5891ddc58a)

make check:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/mds/CDir.h:553:17: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
    _walk_tree([this, &n](CDir *dir) {

zhsgao · 2023-03-02T09:25:24Z

@zhsgao Fails api and make check failure:

API test:

Undefined Reference

Undefined reference in /usr/include/c++/11/bits/stl_map.h:1216 to `Migrator::EXPORT_DISCOVERING'
[Indication 1](https://jenkins.ceph.com/job/ceph-api/51697/consoleFull#-176439654385e1414f-af06-4588-8fed-ab5891ddc58a)

make check:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/mds/CDir.h:553:17: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
    _walk_tree([this, &n](CDir *dir) {

I have modified them, thanks!

vshankar · 2023-03-14T01:59:11Z

jenkins test make check

vshankar · 2023-04-13T04:15:43Z

https://pulpito.ceph.com/vshankar-2023-04-12_10:03:55-fs-wip-vshankar-testing-20230412.053558-testing-default-smithi/

Infra issues with teuthology. Need to rerun tests.

vshankar · 2023-04-20T13:31:27Z

test run: https://pulpito.ceph.com/vshankar-2023-04-20_04:50:51-fs-wip-vshankar-testing-20230412.053558-testing-default-smithi/

vshankar · 2023-04-24T15:09:03Z

@zhsgao I just realized that the test case source test_dump_export_states is missing a reference in a yaml fragment. I remember seeing it when I reviewed it initially. Did you happen to miss including when pushing an update?

zhsgao · 2023-04-25T03:25:49Z

@zhsgao I just realized that the test case source test_dump_export_states is missing a reference in a yaml fragment. I remember seeing it when I reviewed it initially. Did you happen to miss including when pushing an update?

I remember that I didn't modify any yaml file before in this PR. Which yaml file should I modify or add a new one?

vshankar · 2023-04-25T03:37:34Z

@zhsgao I just realized that the test case source test_dump_export_states is missing a reference in a yaml fragment. I remember seeing it when I reviewed it initially. Did you happen to miss including when pushing an update?

I remember that I didn't modify any yaml file before in this PR. Which yaml file should I modify or add a new one?

I recommend moving TestDumpExportStates class to qa/tasks/cephfs/test_exports.py - no need to create a new yaml fragment then.

github-actions · 2023-09-24T20:01:43Z

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

Task to export subtree may be blocked, use this command to find out what's going on. Fixes: https://tracker.ceph.com/issues/58835 Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>

zhsgao · 2024-10-08T13:40:03Z

Can we reopen this PR? @vshankar

vshankar · 2024-10-08T14:04:38Z

Can we reopen this PR? @vshankar

Yes. I've lost a bit of context on this. I'll get back to this.

vshankar · 2024-10-08T14:04:48Z

Reopening.

vshankar · 2024-10-08T14:27:11Z

Not sure why I'm unable to reopen this PR. @zhsgao maybe push an update?

zhsgao · 2024-10-09T03:30:54Z

Not sure why I'm unable to reopen this PR. @zhsgao maybe push an update?

I have rebased and updated this PR, but it is still closed.
Maybe @batrick knows how to reopen it, he recently reopened another closed PR for me.

vshankar · 2024-10-09T07:11:15Z

Hovering over the greyed out "Reopen and comment" tab says

The mds_export_state branch was force-pushed or recreated

@zhsgao Suggest to create e fresh PR.

zhsgao · 2024-10-09T10:15:33Z

Hovering over the greyed out "Reopen and comment" tab says

The mds_export_state branch was force-pushed or recreated

@zhsgao Suggest to create e fresh PR.

The 'reopen' button is greyed out because I force-pushed after the PR was closed. So I have force-pushed the last commit before the PR was closed. The 'reopen' button should be available now if it worked.

vshankar · 2024-10-09T11:46:28Z

Hovering over the greyed out "Reopen and comment" tab says

The mds_export_state branch was force-pushed or recreated

@zhsgao Suggest to create e fresh PR.

The 'reopen' button is greyed out because I force-pushed after the PR was closed. So I have force-pushed the last commit before the PR was closed. The 'reopen' button should be available now if it worked.

Worked! Thx for the work.

vshankar · 2024-10-09T11:46:44Z

@zhsgao please rebase.

github-actions · 2024-10-09T12:07:14Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

zhsgao · 2024-10-10T03:25:05Z

@zhsgao please rebase.

OK, it's done.

vshankar · 2024-10-14T07:24:36Z

@zhsgao please rebase.

OK, it's done.

Thank you!

vshankar · 2024-10-14T07:24:49Z

jenkins test api

vshankar · 2024-10-16T13:58:12Z

This PR is under test in https://tracker.ceph.com/issues/68578.

vshankar

https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-vshankar-testing-20241016135728-debug

github-actions bot added cephfs Ceph File System tests labels Feb 14, 2023

vshankar requested a review from a team February 21, 2023 14:31

zhsgao force-pushed the mds_export_state branch from fca8b93 to 4b32ab6 Compare February 23, 2023 03:17

rishabh-d-dave added the needs-review label Feb 23, 2023

vshankar reviewed Feb 28, 2023

View reviewed changes

src/mds/Migrator.cc Show resolved Hide resolved

dparmar18 reviewed Feb 28, 2023

View reviewed changes

qa/tasks/cephfs/test_dump_export_states.py Outdated Show resolved Hide resolved

dparmar18 reviewed Feb 28, 2023

View reviewed changes

qa/tasks/cephfs/test_dump_export_states.py Outdated Show resolved Hide resolved

dparmar18 reviewed Feb 28, 2023

View reviewed changes

qa/tasks/cephfs/test_dump_export_states.py Outdated Show resolved Hide resolved

mchangir reviewed Feb 28, 2023

View reviewed changes

src/mds/Migrator.h Show resolved Hide resolved

zhsgao force-pushed the mds_export_state branch from 4b32ab6 to 81b862f Compare March 1, 2023 09:53

zhsgao force-pushed the mds_export_state branch from 81b862f to 24d66b3 Compare March 2, 2023 09:19

vshankar requested a review from mchangir March 6, 2023 13:11

zhsgao force-pushed the mds_export_state branch from 24d66b3 to c1892e8 Compare March 9, 2023 04:25

vshankar added the wip-vshankar-testing2 label Mar 14, 2023

vshankar added wip-vshankar-testing3 and removed wip-vshankar-testing2 labels Mar 30, 2023

vshankar removed the wip-vshankar-testing3 label Apr 24, 2023

github-actions bot closed this Sep 24, 2023

zhsgao added 2 commits October 8, 2024 20:30

mds: add an asok command to dump export states

d34f330

Task to export subtree may be blocked, use this command to find out what's going on. Fixes: https://tracker.ceph.com/issues/58835 Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>

qa: add test for 'dump_export_states'

5506ed6

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>

vshankar removed the stale label Oct 8, 2024

vshankar reopened this Oct 9, 2024

github-actions bot added the needs-rebase label Oct 9, 2024

zhsgao force-pushed the mds_export_state branch from a0a3afb to 5506ed6 Compare October 10, 2024 03:13

github-actions bot removed the needs-rebase label Oct 10, 2024

vshankar added needs-qa wip-vshankar-testing3 labels Oct 14, 2024

vshankar approved these changes Oct 30, 2024

View reviewed changes

vshankar merged commit 7809b0e into ceph:main Oct 30, 2024

vshankar removed the wip-vshankar-testing3 label Oct 30, 2024

vshankar mentioned this pull request Nov 26, 2024

squid: mds: add an asok command to dump export states #60836

Merged

mchangir mentioned this pull request Jan 25, 2025

reef: mds: add an asok command to dump export states #61512

Merged

Conversation

zhsgao commented Feb 14, 2023 • edited by dparmar18 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

vshankar commented Feb 21, 2023

Uh oh!

dparmar18 commented Feb 22, 2023

Uh oh!

zhsgao commented Feb 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dparmar18 commented Feb 28, 2023

Uh oh!

vshankar commented Mar 2, 2023

Uh oh!

zhsgao commented Mar 2, 2023

Uh oh!

vshankar commented Mar 14, 2023

Uh oh!

vshankar commented Apr 13, 2023

Uh oh!

vshankar commented Apr 20, 2023

Uh oh!

vshankar commented Apr 24, 2023

Uh oh!

zhsgao commented Apr 25, 2023

Uh oh!

vshankar commented Apr 25, 2023

Uh oh!

github-actions bot commented Sep 24, 2023

Uh oh!

zhsgao commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vshankar commented Oct 8, 2024

Uh oh!

vshankar commented Oct 8, 2024

Uh oh!

vshankar commented Oct 8, 2024

Uh oh!

zhsgao commented Oct 9, 2024

Uh oh!

vshankar commented Oct 9, 2024

Uh oh!

zhsgao commented Oct 9, 2024

Uh oh!

vshankar commented Oct 9, 2024

Uh oh!

vshankar commented Oct 9, 2024

Uh oh!

github-actions bot commented Oct 9, 2024

Uh oh!

zhsgao commented Oct 10, 2024

Uh oh!

vshankar commented Oct 14, 2024

Uh oh!

vshankar commented Oct 14, 2024

Uh oh!

vshankar commented Oct 16, 2024

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zhsgao commented Feb 14, 2023 •

edited by dparmar18

Loading

zhsgao commented Oct 8, 2024 •

edited

Loading