Skip to content

quincy: RGW - Fix NoSuchTagSet error#50103

Merged
cbodley merged 1 commit intoceph:quincyfrom
seanhoughton:wip-55614-quincy
Jul 13, 2023
Merged

quincy: RGW - Fix NoSuchTagSet error#50103
cbodley merged 1 commit intoceph:quincyfrom
seanhoughton:wip-55614-quincy

Conversation

@seanhoughton
Copy link

backport tracker: https://tracker.ceph.com/issues/55614


backport of #46167
parent tracker: https://tracker.ceph.com/issues/55460

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

A bug in AWS documentation caused this to be named "NoSuchTagSetError",
when the proper name (now fixed in the docs) is "NoSuchTagSet".  Fix
this so we match AWS.

Fixes: https://tracker.ceph.com/issues/55460
Author: Peter Gerber <peter@arbitrary.ch>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
@github-actions github-actions bot added the rgw label Feb 14, 2023
@github-actions github-actions bot added this to the quincy milestone Feb 14, 2023
@seanhoughton
Copy link
Author

seanhoughton commented Feb 14, 2023

Note that this bug prevents the AWS Terraform provider from being able to manage RGW buckets and there is no workaround that I can figure out. It would be great to get this pushed out given that quincy is the current version of Ceph.

Also note that the backport script refused to perform the cherry pick automatically and I had to do it manually. I followed the instructions but it just wouldn't work although no error was provided. I didn't alter the original commit message as instructed in the backport doc. Additionally, the instructions for backporting don't work using an alias to use the latest version if you are running the backport script from inside a container.

Thanks!

Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @seanhoughton!

@yuriw
Copy link
Contributor

yuriw commented Feb 22, 2023

ref: https://trello.com/c/ZYnZ4mvk

@cbodley
Copy link
Contributor

cbodley commented Feb 22, 2023

scheduled builds at https://shaman.ceph.com/builds/ceph/wip-cbodley-testing-quincy/ to test this against the s3test branch https://github.com/cbodley/s3-tests/commits/wip-quincy-get-bucket-tagging which includes the fix from ceph/s3-tests#452

@seanhoughton
Copy link
Author

Is there anything holding up this PR that I can resolve? I see 17.2.6 was just released and it would have been nice to have this fix in there...

@seanhoughton
Copy link
Author

Did I do something wrong with the back port process? Why isn't this getting merged?

@cbodley
Copy link
Contributor

cbodley commented Jul 11, 2023

Did I do something wrong with the back port process? Why isn't this getting merged?

@seanhoughton thanks for the reminder. this had failed automated testing because it required a change to ceph/s3-tests#452. i rescheduled this in https://pulpito.ceph.com/cbodley-2023-07-11_20:42:24-rgw-wip-cbodley-testing-quincy-distro-default-smithi/

@cbodley cbodley merged commit c47b864 into ceph:quincy Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants