Skip to content

mon/MgrMap: dump last_failure_osd_epoch and active_clients at top level#50006

Merged
idryomov merged 1 commit intoceph:mainfrom
idryomov:wip-58647
Feb 28, 2023
Merged

mon/MgrMap: dump last_failure_osd_epoch and active_clients at top level#50006
idryomov merged 1 commit intoceph:mainfrom
idryomov:wip-58647

Conversation

@idryomov
Copy link
Contributor

@idryomov idryomov commented Feb 6, 2023

Currently last_failure_osd_epoch and active_clients are dumped in the always_on_modules dictionary in "ceph mgr dump" output. This goes back to when these fields were added in commits f2986a4 ("mon/MgrMonitor: blacklist previous instance") and df507cd ("mgr: forward RADOS client instances for potential blacklist") but is wrong as these fields have nothing to do with always-on modules.

Fixes: https://tracker.ceph.com/issues/58647
Signed-off-by: Ilya Dryomov idryomov@gmail.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation (release note)
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@idryomov idryomov requested a review from a team as a code owner February 6, 2023 17:44
@idryomov idryomov requested a review from batrick February 6, 2023 17:45
@ljflores
Copy link
Member

ljflores commented Feb 6, 2023

@neha-ojha @yaarith I checked this PR with telemetry commands, and it doesn't break anything.

@idryomov
Copy link
Contributor Author

idryomov commented Feb 7, 2023

jenkins test this please

@ajarr ajarr mentioned this pull request Feb 10, 2023
Merged
14 tasks
@idryomov
Copy link
Contributor Author

idryomov commented Feb 10, 2023

jenkins retest this please

@idryomov
Copy link
Contributor Author

idryomov commented Feb 11, 2023

jenkins test api

@ljflores
Copy link
Member

ljflores commented Feb 27, 2023

Rados suite review: https://pulpito.ceph.com/?branch=wip-yuri6-testing-2023-02-24-0805

Failures, unrelated:
1. https://tracker.ceph.com/issues/58585
2. https://tracker.ceph.com/issues/58560
3. https://tracker.ceph.com/issues/58797
4. https://tracker.ceph.com/issues/58744
5. https://tracker.ceph.com/issues/58475

Details:
1. rook: failed to pull kubelet image - Ceph - Orchestrator
2. test_envlibrados_for_rocksdb.sh failed to subscribe to repo - Infrastructure
3. scrub/osd-scrub-dump.sh: TEST_recover_unexpected fails from "ERROR: Unexpectedly low amount of scrub reservations seen during test" - Ceph - RADOS
4. qa: intermittent nfs test failures at nfs cluster creation - Ceph - CephFS
5. test_dashboard_e2e.sh: Conflicting peer dependency: postcss@8.4.21 - Ceph - Mgr - Dashboard

@yuriw
Copy link
Contributor

yuriw commented Feb 27, 2023

@idryomov pls rebase and it's ready for merge
ref: https://trello.com/c/hrTt8qIn

@idryomov
mon/MgrMap: dump last_failure_osd_epoch and active_clients at top level
7b5e161 
Currently last_failure_osd_epoch and active_clients are dumped in the
always_on_modules dictionary in "ceph mgr dump" output.  This goes back
to when these fields were added in commits f2986a4 ("mon/MgrMonitor:
blacklist previous instance") and df507cd ("mgr: forward RADOS
client instances for potential blacklist") but is wrong as these fields
have nothing to do with always-on modules.

Fixes: https://tracker.ceph.com/issues/58647
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@idryomov
Copy link
Contributor Author

idryomov commented Feb 27, 2023

Rebased to address a trivial PendingReleaseNotes conflict.

@idryomov idryomov merged commit 188d7e7 into ceph:main Feb 28, 2023
@idryomov idryomov deleted the wip-58647 branch February 28, 2023 12:31
This was referenced Feb 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajarr ajarr ajarr approved these changes

@batrick batrick Awaiting requested review from batrick

Assignees

No one assigned

Labels

bug-fix core documentation mgr mon needs-qa ready-to-merge TESTED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@idryomov @ljflores @yuriw @ajarr