drive_group: fix limit filter in drive_selection.selector#49969
Merged
drive_group: fix limit filter in drive_selection.selector#49969
Conversation
f664b18 to
96c6168
Compare
adk3798
approved these changes
Feb 7, 2023
575c801 to
0a766d7
Compare
When multiple osd service specs with 'limit' filter are applied, the current logic makes the second service speec try to pick devices that are already used by the first service spec. Fixes: https://tracker.ceph.com/issues/58626 Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
0a766d7 to
8b7da77
Compare
Contributor
|
11 failures, one dead job
|
Contributor
|
failed/dead job reruns: https://pulpito.ceph.com/adking-2023-02-24_17:44:54-orch:cephadm-wip-adk-testing-2023-02-20-1650-distro-default-smithi/ After reruns, 3 failures and 1 dead job
Another instance of this test passed in original run so didn't bother with another rerun
Overall, nothing to block merging. Will note initial version of basic monitoring stack test passed. |
This was referenced Mar 3, 2023
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple osd service specs with 'limit' filter are applied, the current logic makes the second service speec
try to pick devices that are already used by the first service spec.
Fixes: https://tracker.ceph.com/issues/58626
Signed-off-by: Guillaume Abrioux gabrioux@ibm.com